michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: sensor: ti: tmp11x: fix get ambient offset

Browse source 
The sensor value was accidentally set a second time.

Refactor `tmp11x_attr_get` to fix the issue and align more with
`tmp11x_attr_set`.

Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
This commit is contained in:
Jeppe Odgaard 2025-05-12 11:51:06 +02:00 • committed by Fabio Baltieri
commit 46a3bbb35a
1 changed files with 10 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

22
drivers/sensor/ti/tmp11x/tmp11x.c
View file

@ -365,10 +365,14 @@ static int tmp11x_attr_get(const struct device *dev, enum sensor_channel chan,
switch (attr) {
case SENSOR_ATTR_CONFIGURATION:
rc = tmp11x_reg_read(dev, TMP11X_REG_CFGR, &data);
if (rc < 0) {
return rc;
if (rc == 0) {
val->val1 = data;
val->val2 = 0;
}
break;
return rc;
case SENSOR_ATTR_OFFSET:
if (!tmp11x_is_offset_supported(dev->data)) {
LOG_ERR("%s: Offset is not supported", dev->name);
@ -376,20 +380,14 @@ static int tmp11x_attr_get(const struct device *dev, enum sensor_channel chan,
}
rc = tmp11x_reg_read(dev, TMP117_REG_TEMP_OFFSET, &data);
if (rc < 0) {
return rc;
if (rc == 0) {
tmp11x_temperature_to_sensor_value(data, val);
}
tmp11x_temperature_to_sensor_value(data, val);
break;
return rc;
default:
return -ENOTSUP;
}
val->val1 = data;
val->val2 = 0;
return 0;
}
static DEVICE_API(sensor, tmp11x_driver_api) = {