michaelh/zephyr
1
0
Fork 0
Code Releases Activity

native_posix: Check pointer before de-referencing it

Browse source 
To avoid a Coverity warning (203449):
https://github.com/zephyrproject-rtos/zephyr/issues/18354

Initialize a pointer to NULL, and check it later before
de-referencing it.
Coverity could not see that posix_print_error_and_exit()
never returns even that it ends with exit()

Signed-off-by: Alberto Escolar Piedras <alpi@oticon.com>
This commit is contained in:
Alberto Escolar Piedras 2019-08-18 13:56:27 +02:00 • committed by Ioannis Glaropoulos
commit 469accfbe2
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
boards/posix/native_posix/cmdline_common.c
View file

@ -121,7 +121,7 @@ void cmd_read_option_value(const char *str, void *dest, const char type,
const char *option) const char *option)
{ {
int error = 0; int error = 0;
char *endptr; char *endptr = NULL;
switch (type) { switch (type) {
case 'b': case 'b':
@ -162,10 +162,11 @@ void cmd_read_option_value(const char *str, void *dest, const char type,
break; break;
default: default:
posix_print_error_and_exit(CMD_TYPE_ERROR, type); posix_print_error_and_exit(CMD_TYPE_ERROR, type);
/* Unreachable */
break; break;
} }
if (!error && *endptr != 0) { if (!error && endptr && *endptr != 0) {
error = 1; error = 1;
} }