From 463d8f7e8692dea738e4377fc50140fe0789d275 Mon Sep 17 00:00:00 2001
From: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
Date: Wed, 9 Oct 2019 09:38:54 +0200
Subject: [PATCH] arch: arm: clean up inclusions in assembly files

A clean-up commit that removes unnecessary inclusions from
assembly files in arm/core and arm/core/cortex_m. It also
ogranizes the inclusions based on the following order and
set of rules:
- never include kernel_structs.h
- include toolchain.h and linker/sections.h in all ASM files
- include offsets-short.h, if ASM accesses offset constants
- include arch/cpu.h, if ASM accesses CMSIS constants
  (defined locally in include/arch/arm)
- include file-specific headers, if needed (e.g. vector-table.h)

Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
---
 arch/arm/core/cpu_idle.S    | 5 -----
 arch/arm/core/exc_exit.S    | 4 ++--
 arch/arm/core/isr_wrapper.S | 6 +++---
 arch/arm/core/swap_helper.S | 4 ++--
 arch/arm/core/userspace.S   | 4 +---
 5 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/arch/arm/core/cpu_idle.S b/arch/arm/core/cpu_idle.S
index 01d04d7d0c0..a27c143b6b3 100644
--- a/arch/arm/core/cpu_idle.S
+++ b/arch/arm/core/cpu_idle.S
@@ -10,13 +10,8 @@
  *
  */
 
-#include <offsets_short.h>
 #include <toolchain.h>
 #include <linker/sections.h>
-#include <arch/cpu.h>
-#ifdef CONFIG_TICKLESS_IDLE
-#include <kernel_structs.h>
-#endif
 
 _ASM_FILE_PROLOGUE
 
diff --git a/arch/arm/core/exc_exit.S b/arch/arm/core/exc_exit.S
index f1af77e6256..9e3c341057b 100644
--- a/arch/arm/core/exc_exit.S
+++ b/arch/arm/core/exc_exit.S
@@ -14,9 +14,9 @@
  * wrapped around by _isr_wrapper()).
  */
 
-#include <kernel_structs.h>
-#include <offsets_short.h>
 #include <toolchain.h>
+#include <linker/sections.h>
+#include <offsets_short.h>
 #include <arch/cpu.h>
 
 _ASM_FILE_PROLOGUE
diff --git a/arch/arm/core/isr_wrapper.S b/arch/arm/core/isr_wrapper.S
index 5b3b893a008..c83306ea44a 100644
--- a/arch/arm/core/isr_wrapper.S
+++ b/arch/arm/core/isr_wrapper.S
@@ -12,12 +12,12 @@
  * a parameter.
  */
 
-#include <offsets_short.h>
 #include <toolchain.h>
 #include <linker/sections.h>
-#include <sw_isr_table.h>
-#include <kernel_structs.h>
+#include <offsets_short.h>
 #include <arch/cpu.h>
+#include <sw_isr_table.h>
+
 
 _ASM_FILE_PROLOGUE
 
diff --git a/arch/arm/core/swap_helper.S b/arch/arm/core/swap_helper.S
index c6bd30038a8..9cfb343110b 100644
--- a/arch/arm/core/swap_helper.S
+++ b/arch/arm/core/swap_helper.S
@@ -12,9 +12,9 @@
  * on ARM Cortex-M CPUs.
  */
 
-#include <kernel_structs.h>
-#include <offsets_short.h>
 #include <toolchain.h>
+#include <linker/sections.h>
+#include <offsets_short.h>
 #include <arch/cpu.h>
 #include <syscall.h>
 
diff --git a/arch/arm/core/userspace.S b/arch/arm/core/userspace.S
index 5196634f2ea..4a6c9770730 100644
--- a/arch/arm/core/userspace.S
+++ b/arch/arm/core/userspace.S
@@ -7,11 +7,9 @@
  *
  */
 
-#include <offsets_short.h>
 #include <toolchain.h>
 #include <linker/sections.h>
-#include <kernel_structs.h>
-#include <arch/cpu.h>
+#include <offsets_short.h>
 #include <syscall.h>
 
 _ASM_FILE_PROLOGUE