michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: modem: gsm: Command handlers should return value

Browse source 
GSM modem command handlers were missing a return value.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2020-02-10 18:24:42 +02:00
commit 45eccbc5d7
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
drivers/modem/gsm_ppp.c
View file

@ -98,6 +98,7 @@ MODEM_CMD_DEFINE(gsm_cmd_ok)
modem_cmd_handler_set_error(data, 0); modem_cmd_handler_set_error(data, 0);
LOG_DBG("ok"); LOG_DBG("ok");
k_sem_give(&gsm.sem_response); k_sem_give(&gsm.sem_response);
return 0;
} }
MODEM_CMD_DEFINE(gsm_cmd_error) MODEM_CMD_DEFINE(gsm_cmd_error)
@ -105,6 +106,7 @@ MODEM_CMD_DEFINE(gsm_cmd_error)
modem_cmd_handler_set_error(data, -EINVAL); modem_cmd_handler_set_error(data, -EINVAL);
LOG_DBG("error"); LOG_DBG("error");
k_sem_give(&gsm.sem_response); k_sem_give(&gsm.sem_response);
return 0;
} }
static struct modem_cmd response_cmds[] = { static struct modem_cmd response_cmds[] = {
@ -143,6 +145,8 @@ MODEM_CMD_DEFINE(on_cmd_atcmdinfo_manufacturer)
data->rx_buf, 0, len); data->rx_buf, 0, len);
minfo.mdm_manufacturer[out_len] = '\0'; minfo.mdm_manufacturer[out_len] = '\0';
LOG_INF("Manufacturer: %s", log_strdup(minfo.mdm_manufacturer)); LOG_INF("Manufacturer: %s", log_strdup(minfo.mdm_manufacturer));
return 0;
} }
/* Handler: <model> */ /* Handler: <model> */
@ -155,6 +159,8 @@ MODEM_CMD_DEFINE(on_cmd_atcmdinfo_model)
data->rx_buf, 0, len); data->rx_buf, 0, len);
minfo.mdm_model[out_len] = '\0'; minfo.mdm_model[out_len] = '\0';
LOG_INF("Model: %s", log_strdup(minfo.mdm_model)); LOG_INF("Model: %s", log_strdup(minfo.mdm_model));
return 0;
} }
/* Handler: <rev> */ /* Handler: <rev> */
@ -167,6 +173,8 @@ MODEM_CMD_DEFINE(on_cmd_atcmdinfo_revision)
data->rx_buf, 0, len); data->rx_buf, 0, len);
minfo.mdm_revision[out_len] = '\0'; minfo.mdm_revision[out_len] = '\0';
LOG_INF("Revision: %s", log_strdup(minfo.mdm_revision)); LOG_INF("Revision: %s", log_strdup(minfo.mdm_revision));
return 0;
} }
/* Handler: <IMEI> */ /* Handler: <IMEI> */
@ -178,6 +186,8 @@ MODEM_CMD_DEFINE(on_cmd_atcmdinfo_imei)
data->rx_buf, 0, len); data->rx_buf, 0, len);
minfo.mdm_imei[out_len] = '\0'; minfo.mdm_imei[out_len] = '\0';
LOG_INF("IMEI: %s", log_strdup(minfo.mdm_imei)); LOG_INF("IMEI: %s", log_strdup(minfo.mdm_imei));
return 0;
} }
#endif /* CONFIG_MODEM_SHELL */ #endif /* CONFIG_MODEM_SHELL */