michaelh/zephyr
1
0
Fork 0
Code Releases Activity

driver: itim: npcx: check ITEN bit to prevent return fake error.

Browse source 
During polling ITEN bit to make sure ITIM timer is enabled, we might
have the chance that npcx_itim_evt_enable() return fake error when
timeout expired but ITEN bit is set already if CONFIG_ZERO_LATENCY_IRQS
is enabled. (Since SVCall's interrupt priority is not the highest, the
other interrupts with IRQ_ZERO_LATENCY flag could preempt CPU resource
at this moment.)

In order to prevent return fake error code, this CL adjusts the check
conditions for ITEN bit and timeout.

Signed-off-by: Mulin Chao <mlchao@nuvoton.com>
This commit is contained in:
Mulin Chao 2021-04-15 21:00:33 -07:00 • committed by Anas Nashif
commit 440d9dc5d4
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
drivers/timer/npcx_itim_timer.c
View file

@ -113,8 +113,11 @@ static inline int npcx_itim_evt_enable(void)
while (!IS_BIT_SET(evt_tmr->ITCTS32, NPCX_ITCTSXX_ITEN)) { while (!IS_BIT_SET(evt_tmr->ITCTS32, NPCX_ITCTSXX_ITEN)) {
if (npcx_itim_get_sys_cyc64() - cyc_start > if (npcx_itim_get_sys_cyc64() - cyc_start >
NPCX_ITIM_EN_TIMEOUT_CYCLES) { NPCX_ITIM_EN_TIMEOUT_CYCLES) {
LOG_ERR("Timeout: enabling EVT timer!"); /* ITEN bit is still unset? */
return -ETIMEDOUT; if (!IS_BIT_SET(evt_tmr->ITCTS32, NPCX_ITCTSXX_ITEN)) {
LOG_ERR("Timeout: enabling EVT timer!");
return -ETIMEDOUT;
}
} }
} }