michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kernel: resolve static analysis false positives

Browse source 
At least one static analysis tool is flagging a potential NULL
derefence in sys_clock_announce()'s tick processing loop where the
routine 'first()' is concerned. In practice, this does not occur as
...

  1. The code in question is protected by a spinlock.
  2. 'first()' does not change the contents of anything.

The code has consequently been tweaked to prevent similar such false
positives in the future.

Signed-off-by: Peter Mitsis <peter.mitsis@intel.com>
This commit is contained in:
Peter Mitsis 2022-12-14 11:53:58 -05:00 • committed by Fabio Baltieri
commit 42db096d28
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
kernel/timeout.c
View file

@ -258,8 +258,11 @@ void sys_clock_announce(int32_t ticks)
announce_remaining = ticks; announce_remaining = ticks;
while (first() != NULL && first()->dticks <= announce_remaining) { struct _timeout *t = first();
struct _timeout *t = first();
for (t = first();
(t != NULL) && (t->dticks <= announce_remaining);
t = first()) {
int dt = t->dticks; int dt = t->dticks;
curr_tick += dt; curr_tick += dt;
@ -272,8 +275,8 @@ void sys_clock_announce(int32_t ticks)
announce_remaining -= dt; announce_remaining -= dt;
} }
if (first() != NULL) { if (t != NULL) {
first()->dticks -= announce_remaining; t->dticks -= announce_remaining;
} }
curr_tick += announce_remaining; curr_tick += announce_remaining;