michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: i2c: Fix get_regs() to happen after DEVICE_MMIO_MAP

Browse source 
Fixing a bug where get_regs() was being executed before MMIO mapping
moving the declaration of reg_base after DEVICE_MMIO_MAP

Signed-off-by: Esteban Valverde <esteban.valverde.vega@intel.com>
This commit is contained in:
Esteban Valverde 2022-04-28 16:53:06 +01:00 • committed by Carles Cufí
commit 426c1f6aff
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/i2c/i2c_dw.c
View file

@ -838,7 +838,6 @@ static int i2c_dw_initialize(const struct device *dev)
const struct i2c_dw_rom_config * const rom = dev->config; const struct i2c_dw_rom_config * const rom = dev->config;
struct i2c_dw_dev_config * const dw = dev->data; struct i2c_dw_dev_config * const dw = dev->data;
union ic_con_register ic_con; union ic_con_register ic_con;
uint32_t reg_base = get_regs(dev);
int ret = 0; int ret = 0;
#if defined(CONFIG_PINCTRL) #if defined(CONFIG_PINCTRL)
@ -868,6 +867,7 @@ static int i2c_dw_initialize(const struct device *dev)
} }
k_sem_init(&dw->device_sync_sem, 0, K_SEM_MAX_LIMIT); k_sem_init(&dw->device_sync_sem, 0, K_SEM_MAX_LIMIT);
uint32_t reg_base = get_regs(dev);
/* verify that we have a valid DesignWare register first */ /* verify that we have a valid DesignWare register first */
if (read_comp_type(reg_base) != I2C_DW_MAGIC_KEY) { if (read_comp_type(reg_base) != I2C_DW_MAGIC_KEY) {