michaelh/zephyr
1
0
Fork 0
Code Releases Activity

scripts: elf_helper: Tidy up get_symbols() to eliminate pylint warning

Browse source 
Using a member variable in the dict comprehension was probably a typo
(can't see 'sym' referenced elsewhere). Use a local variable instead.

Made pylint spit out these warnings (which might be spurious though):

    scripts/elf_helper.py:535:24: E0203: Access to member 'sym' before
    its definition line 536 (access-member-before-definition)

    scripts/elf_helper.py:535:39: E0203: Access to member 'sym' before
    its definition line 536 (access-member-before-definition)

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2019-03-20 20:24:21 +01:00 • committed by Kumar Gala
commit 425998bd79
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
scripts/elf_helper.py
View file

@ -533,8 +533,8 @@ class ElfHelper:
def get_symbols(self):
for section in self.elf.iter_sections():
if isinstance(section, SymbolTableSection):
return {self.sym.name: self.sym.entry.st_value
for self.sym in section.iter_symbols()}
return {sym.name: sym.entry.st_value
for sym in section.iter_symbols()}
raise LookupError("Could not find symbol table")