michaelh/zephyr
1
0
Fork 0
Code Releases Activity

dma: Fix error_callback enable/disable confusion

Browse source 
Previously the logic was inverted for error_callback_en where 0 was
enablement and 1 was disable. This was likely done so that the default,
sensibly so, was to enable the error callback if possible. A variety of
in tree users had confused the enable/disable value.

Change the name of the flag to error_callback_dis where the default
remains 0 (do not disable the callback!) and correct in tree uses of the
flag where it seemed incorrect.

Signed-off-by: Tom Burdick <thomas.burdick@intel.com>
This commit is contained in:
Tom Burdick 2024-04-09 14:06:25 -05:00 • committed by Anas Nashif
commit 4180d70439
20 changed files with 32 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/spi/spi_mcux_dspi.c
View file

@ -836,7 +836,7 @@ static const struct spi_driver_api spi_mcux_driver_api = {
.dest_data_size = 4, \
.dma_callback = dma_callback, \
.complete_callback_en = 1, \
.error_callback_en = 1, \
.error_callback_dis = 0, \
.block_count = 1, \
.head_block = &spi_mcux_data_##id.tx_dma_block, \
.channel_direction = MEMORY_TO_PERIPHERAL, \
@ -857,7 +857,7 @@ static const struct spi_driver_api spi_mcux_driver_api = {
.dest_data_size = 2, \
.dma_callback = dma_callback, \
.complete_callback_en = 1, \
.error_callback_en = 1, \
.error_callback_dis = 0, \
.block_count = \
_UTIL_AND2(DT_INST_NODE_HAS_PROP( \
id, nxp_rx_tx_chn_share), 2), \