michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: serial: ns16550: fix uart initialization

Browse source 
Do not set DLAB bit in Line Control Register when the access to
the baud rate divisor registers is not needed.

Signed-off-by: Dawid Niedzwiecki <dn@semihalf.com>
This commit is contained in:
Dawid Niedzwiecki 2021-09-09 13:06:18 +02:00 • committed by Anas Nashif
commit 3e696a0f84
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/serial/uart_ns16550.c
View file

@ -339,7 +339,6 @@ static int uart_ns16550_configure(const struct device *dev,
{ {
struct uart_ns16550_dev_data * const dev_data = DEV_DATA(dev); struct uart_ns16550_dev_data * const dev_data = DEV_DATA(dev);
const struct uart_ns16550_device_config * const dev_cfg = DEV_CFG(dev); const struct uart_ns16550_device_config * const dev_cfg = DEV_CFG(dev);
uint8_t lcr_cache;
uint8_t mdc = 0U; uint8_t mdc = 0U;
/* temp for return value if error occurs in this locked region */ /* temp for return value if error occurs in this locked region */
@ -466,10 +465,7 @@ static int uart_ns16550_configure(const struct device *dev,
); );
/* clear the port */ /* clear the port */
lcr_cache = INBYTE(LCR(dev));
OUTBYTE(LCR(dev), LCR_DLAB | lcr_cache);
INBYTE(RDR(dev)); INBYTE(RDR(dev));
OUTBYTE(LCR(dev), lcr_cache);
/* disable interrupts */ /* disable interrupts */
OUTBYTE(IER(dev), 0x00); OUTBYTE(IER(dev), 0x00);