michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: nxp_enet: Use hwinfo API for unique mac

Browse source 
Use the HWINFO API for getting the unique mac address, and use the
pre-existing hardcoded macros as fallbacks if hwinfo is not implemented
properly.

Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
This commit is contained in:
Declan Snyder 2025-06-10 12:09:43 -05:00 • committed by Anas Nashif
commit 3d8196f41b
2 changed files with 24 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/ethernet/Kconfig.nxp_enet
View file

@ -4,6 +4,8 @@
# Copyright 2024-2025 NXP # Copyright 2024-2025 NXP
# SPDX-License-Identifier: Apache-2.0 # SPDX-License-Identifier: Apache-2.0
DT_NXP_UNIQUE_MAC_PROP := nxp,unique-mac
config ETH_NXP_ENET config ETH_NXP_ENET
bool "NXP ENET Ethernet driver" bool "NXP ENET Ethernet driver"
default y default y
@ -14,6 +16,7 @@ config ETH_NXP_ENET
select NET_POWER_MANAGEMENT if (PM_DEVICE && SOC_FAMILY_KINETIS) select NET_POWER_MANAGEMENT if (PM_DEVICE && SOC_FAMILY_KINETIS)
select ETH_DSA_SUPPORT_DEPRECATED select ETH_DSA_SUPPORT_DEPRECATED
select PINCTRL select PINCTRL
select HWINFO if $(dt_compat_any_has_prop,$(DT_COMPAT_NXP_ENET_MAC),$(DT_NXP_UNIQUE_MAC_PROP),True)
help help
Enable NXP ENET Ethernet driver. Enable NXP ENET Ethernet driver.

22
drivers/ethernet/eth_nxp_enet.c
View file

@ -34,6 +34,7 @@ LOG_MODULE_REGISTER(LOG_MODULE_NAME);
#include <zephyr/drivers/pinctrl.h> #include <zephyr/drivers/pinctrl.h>
#include <zephyr/drivers/clock_control.h> #include <zephyr/drivers/clock_control.h>
#include <zephyr/drivers/hwinfo.h>
#ifdef CONFIG_PTP_CLOCK #ifdef CONFIG_PTP_CLOCK
#include <zephyr/drivers/ptp_clock.h> #include <zephyr/drivers/ptp_clock.h>
@ -641,12 +642,28 @@ static const struct device *eth_nxp_enet_get_phy(const struct device *dev)
return config->phy_dev; return config->phy_dev;
} }
/* we enable HWINFO from kconfig if the relevant DT prop is in the tree */
#ifdef CONFIG_HWINFO
/* Note this is not universally unique, it just is probably unique on a network */ /* Note this is not universally unique, it just is probably unique on a network */
static inline void nxp_enet_unique_mac(uint8_t *mac_addr) static inline void nxp_enet_unique_mac(uint8_t *mac_addr)
{ {
uint32_t id = ETH_NXP_ENET_UNIQUE_ID; uint8_t id_buf[3];
uint32_t id = 0;
int ret;
ret = hwinfo_get_device_id(id_buf, sizeof(id_buf));
if (ret == sizeof(id_buf)) {
id |= FIELD_PREP(0xFF0000, id_buf[2]);
id |= FIELD_PREP(0x00FF00, id_buf[1]);
id |= FIELD_PREP(0x0000FF, id_buf[0]);
} else {
/* Either implemented wrong, implemented insufficiently, or not at all */
/* This is fallback for platforms that don't have HWINFO properly */
id = ETH_NXP_ENET_UNIQUE_ID;
}
if (id == 0xFFFFFF) { if (id == 0xFFFFFF) {
/* Allowed but should raise highest level error notice to user */
LOG_ERR("No unique MAC can be provided in this platform"); LOG_ERR("No unique MAC can be provided in this platform");
} }
@ -658,6 +675,9 @@ static inline void nxp_enet_unique_mac(uint8_t *mac_addr)
mac_addr[4] = FIELD_GET(0x00FF00, id); mac_addr[4] = FIELD_GET(0x00FF00, id);
mac_addr[5] = FIELD_GET(0x0000FF, id); mac_addr[5] = FIELD_GET(0x0000FF, id);
} }
#else
#define nxp_enet_unique_mac(...)
#endif
#ifdef CONFIG_SOC_FAMILY_NXP_IMXRT #ifdef CONFIG_SOC_FAMILY_NXP_IMXRT
#include <fsl_ocotp.h> #include <fsl_ocotp.h>