michaelh/zephyr
1
0
Fork 0
Code Releases Activity

include/devicetree: dma: cleanup params to DT_*DMAS_CELL_BY_NAME

Browse source 
The params in the macro's were a bit confused in what was cell_name and
what was name.  The order was correct and matched other _BY_NAME macros.
Rename the params to just 'name' and 'cell' to match other macro's and
fix any other minor issues associated with this confusion.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
This commit is contained in:
Kumar Gala 2020-04-20 16:11:20 -05:00 • committed by Kumar Gala
commit 3b96e4f71c
1 changed files with 8 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

18
include/devicetree/dma.h
View file

@ -186,31 +186,29 @@ extern "C" {
* *
* Example usage: * Example usage:
* *
* DT_DMAS_CELL_BY_NAME(DT_NODELABEL(n), channel, tx) // 1 * DT_DMAS_CELL_BY_NAME(DT_NODELABEL(n), tx, channel) // 1
* DT_DMAS_CELL_BY_NAME(DT_NODELABEL(n), config, rx) // 0x404 * DT_DMAS_CELL_BY_NAME(DT_NODELABEL(n), rx, config) // 0x404
* *
* @param node_id node identifier * @param node_id node identifier
* @param cell_name binding's cell name within the specifier referenced
* as "name"
* @param name lowercase-and-underscores dma channel specifier name * @param name lowercase-and-underscores dma channel specifier name
* @param cell binding's cell name within the specifier referenced as "name"
* @return the value of "cell" inside the dma channel specifier * @return the value of "cell" inside the dma channel specifier
* @see DT_PHA_PHANDLE_IDX() * @see DT_PHA_PHANDLE_IDX()
*/ */
#define DT_DMAS_CELL_BY_NAME(node_id, cell_name, name) \ #define DT_DMAS_CELL_BY_NAME(node_id, name, cell) \
DT_PHA_BY_NAME(node_id, dmas, cell_name, name) DT_PHA_BY_NAME(node_id, dmas, name, cell)
/** /**
* @brief Get dma channel specifier cell value by name * @brief Get dma channel specifier cell value by name
* (see @ref DT_DMAS_CELL_BY_NAME) * (see @ref DT_DMAS_CELL_BY_NAME)
* @param inst instance number * @param inst instance number
* @param name lowercase-and-underscores dma channel specifier name * @param name lowercase-and-underscores dma channel specifier name
* @param cell_name binding's cell name within the specifier referenced * @param cell binding's cell name within the specifier referenced as "name"
* as "name"
* @return the value of "cell" inside the specifier * @return the value of "cell" inside the specifier
*/ */
#define DT_INST_DMAS_CELL_BY_NAME(inst, cell_name, name) \ #define DT_INST_DMAS_CELL_BY_NAME(inst, name, cell) \
DT_DMAS_CELL_BY_NAME(DT_DRV_INST(inst), cell_name, name) DT_DMAS_CELL_BY_NAME(DT_DRV_INST(inst), name, cell)
/** /**
* @brief Does a DMA client have a channel specifier at an index? * @brief Does a DMA client have a channel specifier at an index?