michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: sensor: bmi270: Update driver to use i2c_dt_spec

Browse source 
Simplify driver by using i2c_dt_spec for bus access.

Signed-off-by: Benjamin Björnsson <benjamin.bjornsson@gmail.com>
This commit is contained in:
Benjamin Björnsson 2022-06-16 20:20:22 +02:00 • committed by Maureen Helm
commit 3b2f21e291
2 changed files with 10 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

20
drivers/sensor/bmi270/bmi270.c
View file

@ -25,16 +25,16 @@ LOG_MODULE_REGISTER(bmi270, CONFIG_SENSOR_LOG_LEVEL);
static int reg_read(const struct device *dev, uint8_t reg, uint8_t *data, uint16_t length)
{
struct bmi270_data *drv_dev = dev->data;
const struct bmi270_dev_config *cfg = dev->config;
return i2c_burst_read(drv_dev->i2c, drv_dev->i2c_addr, reg, data, length);
return i2c_burst_read_dt(&cfg->i2c, reg, data, length);
}
static int reg_write(const struct device *dev, uint8_t reg, const uint8_t *data, uint16_t length)
{
struct bmi270_data *drv_dev = dev->data;
const struct bmi270_dev_config *cfg = dev->config;
return i2c_burst_write(drv_dev->i2c, drv_dev->i2c_addr, reg, data, length);
return i2c_burst_write_dt(&cfg->i2c, reg, data, length);
}
static int reg_write_with_delay(const struct device *dev, uint8_t reg, const uint8_t *data,
@ -592,14 +592,11 @@ static int bmi270_init(const struct device *dev)
uint8_t tries;
uint8_t adv_pwr_save;
drv_dev->i2c = device_get_binding(cfg->i2c_master_name);
if (drv_dev->i2c == NULL) {
LOG_ERR("Could not get pointer to %s device",
cfg->i2c_master_name);
return -EINVAL;
if (!device_is_ready(cfg->i2c.bus)) {
LOG_ERR("I2C bus device not ready");
return -ENODEV;
}
drv_dev->i2c_addr = cfg->i2c_addr;
drv_dev->acc_odr = BMI270_ACC_ODR_100_HZ;
drv_dev->acc_range = 8;
drv_dev->gyr_odr = BMI270_GYR_ODR_200_HZ;
@ -700,8 +697,7 @@ static const struct sensor_driver_api bmi270_driver_api = {
static struct bmi270_data bmi270_drv_##inst; \
\
static const struct bmi270_dev_config bmi270_config_##inst = { \
.i2c_master_name = DT_INST_BUS_LABEL(inst), \
.i2c_addr = DT_INST_REG_ADDR(inst), \
.i2c = I2C_DT_SPEC_INST_GET(inst), \
}; \
\
DEVICE_DT_INST_DEFINE(inst, \

6
drivers/sensor/bmi270/bmi270.h
View file

@ -11,6 +11,7 @@
#include <zephyr/sys/util.h>
#include <zephyr/types.h>
#include <zephyr/drivers/sensor.h>
#include <zephyr/drivers/i2c.h>
#define BMI270_REG_CHIP_ID 0x00
#define BMI270_REG_ERROR 0x02
@ -200,16 +201,13 @@
((reg_data & ~(bitname##_MSK)) | (data & bitname##_MSK))
struct bmi270_data {
const struct device *i2c;
uint8_t i2c_addr;
int16_t ax, ay, az, gx, gy, gz;
uint8_t acc_range, acc_odr, gyr_odr;
uint16_t gyr_range;
};
struct bmi270_dev_config {
const char *i2c_master_name;
uint16_t i2c_addr;
struct i2c_dt_spec i2c;
};
#endif /* ZEPHYR_DRIVERS_SENSOR_BMI270_BMI270_H_ */