michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: spi: replace timeout for STM32 DMA slave mode

Browse source 
Replace the timeout for a SPI transceive in slave mode for STM32 DMA
operations with a K_FOREVER. Being an SPI slave means we do not
know when the transaction will start, hence it does not make sense
to have a timeout in such a case.
This will resolve issue #60000.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
This commit is contained in:
Benedikt Schmidt 2023-07-04 13:28:33 +02:00 • committed by Carles Cufí
commit 39391b4a16
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
drivers/spi/spi_ll_stm32.c
View file

@ -693,9 +693,20 @@ static int wait_dma_rx_tx_done(const struct device *dev)
{
struct spi_stm32_data *data = dev->data;
int res = -1;
k_timeout_t timeout;
/*
* In slave mode we do not know when the transaction will start. Hence,
* it doesn't make sense to have timeout in this case.
*/
if (IS_ENABLED(CONFIG_SPI_SLAVE) && spi_context_is_slave(&data->ctx)) {
timeout = K_FOREVER;
} else {
timeout = K_MSEC(1000);
}
while (1) {
res = k_sem_take(&data->status_sem, K_MSEC(1000));
res = k_sem_take(&data->status_sem, timeout);
if (res != 0) {
return res;
}