michaelh/zephyr
1
0
Fork 0
Code Releases Activity

shell: Consume all input data

Browse source 
A transport may receive multiple bytes of data between shell_thread
wakeups, but state_collect is only called once per wakeup.  So it must
process all data, and only return when all data from the transport has
been consumed.  This is mostly handled correctly, but there were two
places where state_collect would return early instead.

Signed-off-by: Jim Paris <jim@jtan.com>
This commit is contained in:
Jim Paris 2019-04-05 16:52:50 -04:00 • committed by Anas Nashif
commit 38ecf5b41f
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
subsys/shell/shell.c
View file

@ -882,7 +882,7 @@ static void state_collect(const struct shell *shell)
* on received NL.
*/
state_set(shell, SHELL_STATE_ACTIVE);
return;
continue;
}
switch (data) {
@ -950,7 +950,7 @@ static void state_collect(const struct shell *shell)
receive_state_change(shell, SHELL_RECEIVE_DEFAULT);
if (!flag_echo_get(shell)) {
return;
continue;
}
switch (data) {