michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: spi: ambiq: optimize ambiq spi device pm

Browse source 
This commit optimizes the device pm for ambiq spi driver
by adding pinctrl sleep/resume.

Signed-off-by: Hao Luo <hluo@ambiq.com>
This commit is contained in:
Hao Luo 2025-06-05 09:58:21 +08:00 • committed by Benjamin Cabé
commit 373ab289ce
2 changed files with 46 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

27
drivers/spi/spi_ambiq_spic.c
View file

@ -465,25 +465,44 @@ end:
#ifdef CONFIG_PM_DEVICE #ifdef CONFIG_PM_DEVICE
static int spi_ambiq_pm_action(const struct device *dev, enum pm_device_action action) static int spi_ambiq_pm_action(const struct device *dev, enum pm_device_action action)
{ {
const struct spi_ambiq_config *cfg = dev->config;
struct spi_ambiq_data *data = dev->data; struct spi_ambiq_data *data = dev->data;
uint32_t ret; int err;
am_hal_sysctrl_power_state_e status; am_hal_sysctrl_power_state_e status;
switch (action) { switch (action) {
case PM_DEVICE_ACTION_RESUME: case PM_DEVICE_ACTION_RESUME:
/* Set pins to active state */
err = pinctrl_apply_state(cfg->pcfg, PINCTRL_STATE_DEFAULT);
if (err < 0) {
return err;
}
status = AM_HAL_SYSCTRL_WAKE; status = AM_HAL_SYSCTRL_WAKE;
break; break;
case PM_DEVICE_ACTION_SUSPEND: case PM_DEVICE_ACTION_SUSPEND:
/* Move pins to sleep state */
err = pinctrl_apply_state(cfg->pcfg, PINCTRL_STATE_SLEEP);
if ((err < 0) && (err != -ENOENT)) {
/*
* If returning -ENOENT, no pins where defined for sleep mode :
* Do not output on console (might sleep already) when going to
* sleep,
* "SPI pinctrl sleep state not available"
* and don't block PM suspend.
* Else return the error.
*/
return err;
}
status = AM_HAL_SYSCTRL_DEEPSLEEP; status = AM_HAL_SYSCTRL_DEEPSLEEP;
break; break;
default: default:
return -ENOTSUP; return -ENOTSUP;
} }
ret = am_hal_iom_power_ctrl(data->iom_handler, status, true); err = am_hal_iom_power_ctrl(data->iom_handler, status, true);
if (ret != AM_HAL_STATUS_SUCCESS) { if (err != AM_HAL_STATUS_SUCCESS) {
LOG_ERR("am_hal_iom_power_ctrl failed: %d", ret); LOG_ERR("am_hal_iom_power_ctrl failed: %d", err);
return -EPERM; return -EPERM;
} else { } else {
return 0; return 0;

27
drivers/spi/spi_ambiq_spid.c
View file

@ -364,24 +364,43 @@ end:
#ifdef CONFIG_PM_DEVICE #ifdef CONFIG_PM_DEVICE
static int spi_ambiq_pm_action(const struct device *dev, enum pm_device_action action) static int spi_ambiq_pm_action(const struct device *dev, enum pm_device_action action)
{ {
const struct spi_ambiq_config *cfg = dev->config;
struct spi_ambiq_data *data = dev->data; struct spi_ambiq_data *data = dev->data;
uint32_t ret; int err;
am_hal_sysctrl_power_state_e status; am_hal_sysctrl_power_state_e status;
switch (action) { switch (action) {
case PM_DEVICE_ACTION_RESUME: case PM_DEVICE_ACTION_RESUME:
/* Set pins to active state */
err = pinctrl_apply_state(cfg->pcfg, PINCTRL_STATE_DEFAULT);
if (err < 0) {
return err;
}
status = AM_HAL_SYSCTRL_WAKE; status = AM_HAL_SYSCTRL_WAKE;
break; break;
case PM_DEVICE_ACTION_SUSPEND: case PM_DEVICE_ACTION_SUSPEND:
/* Move pins to sleep state */
err = pinctrl_apply_state(cfg->pcfg, PINCTRL_STATE_SLEEP);
if ((err < 0) && (err != -ENOENT)) {
/*
* If returning -ENOENT, no pins where defined for sleep mode :
* Do not output on console (might sleep already) when going to
* sleep,
* "SPI pinctrl sleep state not available"
* and don't block PM suspend.
* Else return the error.
*/
return err;
}
status = AM_HAL_SYSCTRL_DEEPSLEEP; status = AM_HAL_SYSCTRL_DEEPSLEEP;
break; break;
default: default:
return -ENOTSUP; return -ENOTSUP;
} }
ret = am_hal_ios_power_ctrl(data->ios_handler, status, true); err = am_hal_ios_power_ctrl(data->ios_handler, status, true);
if (ret != AM_HAL_STATUS_SUCCESS) { if (err != AM_HAL_STATUS_SUCCESS) {
LOG_ERR("am_hal_ios_power_ctrl failed: %d", ret); LOG_ERR("am_hal_ios_power_ctrl failed: %d", err);
return -EPERM; return -EPERM;
} else { } else {
return 0; return 0;