michaelh/zephyr
1
0
Fork 0
Code Releases Activity

sensor: adxl345: Allow fifo-watermark configurable through dts

Browse source 
Allow for users to define the fifo-watermark on a per-instance basis
through device-tree properties. This setting is validated at build
time, so missing it when required, or setting an invalid value should
not end up in a run-time errror (as in: it runs but nothing happens).

Signed-off-by: Luis Ubieda <luisf@croxel.com>
This commit is contained in:
Luis Ubieda 2025-04-10 14:55:00 -04:00 • committed by Benjamin Cabé
commit 36917d4809
2 changed files with 21 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
drivers/sensor/adi/adxl345/adxl345.c
View file

@ -482,7 +482,7 @@ static int adxl345_init(const struct device *dev)
#ifdef CONFIG_ADXL345_TRIGGER
rc = adxl345_configure_fifo(dev, ADXL345_FIFO_STREAMED,
ADXL345_INT2,
SAMPLE_NUM);
cfg->fifo_config.fifo_samples);
if (rc) {
return rc;
}
@ -561,7 +561,7 @@ static int adxl345_init(const struct device *dev)
.odr = DT_INST_PROP(inst, odr), \
.fifo_config.fifo_mode = ADXL345_FIFO_STREAMED, \
.fifo_config.fifo_trigger = ADXL345_INT2, \
.fifo_config.fifo_samples = SAMPLE_NUM, \
.fifo_config.fifo_samples = DT_INST_PROP_OR(inst, fifo_watermark, 0),
#define ADXL345_CONFIG_SPI(inst) \
{ \
@ -590,7 +590,19 @@ static int adxl345_init(const struct device *dev)
(ADXL345_CFG_IRQ(inst)), ()) \
}
#define ADXL345_DEFINE(inst) \
#define ADXL345_DEFINE(inst) \
\
BUILD_ASSERT(!IS_ENABLED(CONFIG_ADXL345_STREAM) || \
DT_INST_NODE_HAS_PROP(inst, fifo_watermark), \
"Streaming requires fifo-watermark property. Please set it in the" \
"device-tree node properties"); \
BUILD_ASSERT(COND_CODE_1(DT_INST_NODE_HAS_PROP(inst, fifo_watermark), \
((DT_INST_PROP(inst, fifo_watermark) > 0) && \
(DT_INST_PROP(inst, fifo_watermark) < 32)), \
(true)), \
"fifo-watermark must be between 1 and 32. Please set it in " \
"the device-tree node properties"); \
\
IF_ENABLED(CONFIG_ADXL345_STREAM, (ADXL345_RTIO_DEFINE(inst))); \
static struct adxl345_dev_data adxl345_data_##inst = { \
IF_ENABLED(CONFIG_ADXL345_STREAM, (.rtio_ctx = &adxl345_rtio_ctx_##inst, \

6
dts/bindings/sensor/adi,adxl345-common.yaml
View file

@ -31,6 +31,12 @@ properties:
- 11 # ADXL345_DT_ODR_200
- 12 # ADXL345_DT_ODR_400
fifo-watermark:
type: int
description: |
Specify the FIFO watermark level in frame count.
Valid range: 1 - 31
int2-gpios:
type: phandle-array
description: |