michaelh/zephyr
1
0
Fork 0
Code Releases Activity

ztest: Update verification to account for missing suite

Browse source 
Fix an issue where a test's suite name was misspelled and thus the
test never ran because it wasn't associated with a suite. Example:

ZTEST_SUITE(my_suite, NULL, NULL, NULL, NULL, NULL);
ZTEST(myy_suite, test)
{
}

The above will no longer pass since `myy_suite` with a double `y` will
fail the verification.

Signed-off-by: Yuval Peress <peress@google.com>
This commit is contained in:
Yuval Peress 2022-02-03 14:00:31 -07:00 • committed by Anas Nashif
commit 35ec3c9579
1 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
subsys/testsuite/ztest/src/ztest_new.c
View file

@ -555,11 +555,21 @@ int ztest_run_test_suites(const void *state)
void ztest_verify_all_test_suites_ran(void)
{
bool all_tests_run = true;
struct ztest_suite_node *ptr;
struct ztest_suite_node *suite;
struct ztest_unit_test *test;
for (ptr = _ztest_suite_node_list_start; ptr < _ztest_suite_node_list_end; ++ptr) {
if (ptr->stats.run_count < 1) {
PRINT("ERROR: Test '%s' did not run.\n", ptr->name);
for (suite = _ztest_suite_node_list_start; suite < _ztest_suite_node_list_end; ++suite) {
if (suite->stats.run_count < 1) {
PRINT("ERROR: Test suite '%s' did not run.\n", suite->name);
all_tests_run = false;
}
}
for (test = _ztest_unit_test_list_start; test < _ztest_unit_test_list_end; ++test) {
suite = ztest_find_test_suite(test->test_suite_name);
if (suite == NULL) {
PRINT("ERROR: Test '%s' assigned to test suite '%s' which doesn't exist\n",
test->name, test->test_suite_name);
all_tests_run = false;
}
}