michaelh/zephyr
1
0
Fork 0
Code Releases Activity

soc: x86: Make statements evaluate boolean expressions

Browse source 
MISRA-C requires that the if statement has essentially Boolean type.

MISRA-C rule 14.4

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2018-12-17 16:04:25 -08:00 • committed by Anas Nashif
commit 353933125f
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
soc/x86/intel_quark/quark_se/soc.c
View file

@ -68,7 +68,7 @@ int _arc_init(struct device *arg)
ARG_UNUSED(arg); ARG_UNUSED(arg);
if (!SCSS_REG_VAL(SCSS_SS_STS)) { if (SCSS_REG_VAL(SCSS_SS_STS) == 0) {
/* ARC shouldn't already be running! */ /* ARC shouldn't already be running! */
printk("ARC core already running!"); printk("ARC core already running!");
return -EIO; return -EIO;
@ -81,7 +81,7 @@ int _arc_init(struct device *arg)
LOG_DBG("Reset vector address: %x", *reset_vector); LOG_DBG("Reset vector address: %x", *reset_vector);
shared_data->arc_start = *reset_vector; shared_data->arc_start = *reset_vector;
shared_data->flags = 0U; shared_data->flags = 0U;
if (!shared_data->arc_start) { if (shared_data->arc_start == 0) {
/* Reset vector points to NULL => skip ARC init. */ /* Reset vector points to NULL => skip ARC init. */
LOG_DBG("Reset vector is NULL, skipping ARC init."); LOG_DBG("Reset vector is NULL, skipping ARC init.");
goto skip_arc_init; goto skip_arc_init;
@ -94,13 +94,13 @@ int _arc_init(struct device *arg)
LOG_DBG("Waiting for arc to start..."); LOG_DBG("Waiting for arc to start...");
/* Block until the ARC core actually starts up */ /* Block until the ARC core actually starts up */
while (SCSS_REG_VAL(SCSS_SS_STS) & 0x4000) { while ((SCSS_REG_VAL(SCSS_SS_STS) & 0x4000) != 0) {
} }
/* Block until ARC's quark_se_init() sets a flag indicating it is ready, /* Block until ARC's quark_se_init() sets a flag indicating it is ready,
* if we get stuck here ARC has run but has exploded very early */ * if we get stuck here ARC has run but has exploded very early */
LOG_DBG("Waiting for arc to init..."); LOG_DBG("Waiting for arc to init...");
while (!(shared_data->flags & ARC_READY)) { while ((shared_data->flags & ARC_READY) == 0) {
} }
skip_arc_init: skip_arc_init: