michaelh/zephyr
1
0
Fork 0
Code Releases Activity

bluetooth: ias: Fix dereferencing before NULL check

Browse source 
It does make sense to dereference after NULL check.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
This commit is contained in:
Andrei Emeltchenko 2023-01-18 11:55:33 +02:00 • committed by Anas Nashif
commit 33b0c0db38
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
subsys/bluetooth/services/ias/ias_client.c
View file

@ -96,7 +96,7 @@ static uint8_t bt_ias_alert_lvl_disc_cb(struct bt_conn *conn,
const struct bt_gatt_attr *attr, const struct bt_gatt_attr *attr,
struct bt_gatt_discover_params *discover) struct bt_gatt_discover_params *discover)
{ {
const struct bt_gatt_chrc *chrc = (struct bt_gatt_chrc *)attr->user_data; const struct bt_gatt_chrc *chrc;
atomic_clear_bit(client_by_conn(conn)->flags, IAS_DISCOVER_IN_PROGRESS); atomic_clear_bit(client_by_conn(conn)->flags, IAS_DISCOVER_IN_PROGRESS);
@ -106,6 +106,8 @@ static uint8_t bt_ias_alert_lvl_disc_cb(struct bt_conn *conn,
return BT_GATT_ITER_STOP; return BT_GATT_ITER_STOP;
} }
chrc = (struct bt_gatt_chrc *)attr->user_data;
client_by_conn(conn)->alert_level_handle = chrc->value_handle; client_by_conn(conn)->alert_level_handle = chrc->value_handle;
discover_complete(conn, 0); discover_complete(conn, 0);