michaelh/zephyr
1
0
Fork 0
Code Releases Activity

x86: 32-bit: allow direct ISRs only with !KPTI

Browse source 
This doesn't work as expected with kernel page table isolation
turned on, and fixing it would likely lose any latency benefits
that direct ISRs are supposed to provide.

For now, just prevent these macros from being defined if KPTI
is turned on, like other arches that do not implement this
feature.

Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
This commit is contained in:
Andrew Boie 2020-05-27 14:36:49 -07:00 • committed by Carles Cufí
commit 32ebe3cd24
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
include/arch/x86/ia32/arch.h
View file

@ -204,6 +204,14 @@ typedef struct s_isrList {
(flags_p)); \ (flags_p)); \
} }
/* Direct interrupts won't work as expected with KPTI turned on, because
* all non-user accessible pages in the page table are marked non-present.
* It's likely possible to add logic to ARCH_ISR_DIRECT_HEADER/FOOTER to do
* the necessary trampolining to switch page tables / stacks, but this
* probably loses all the latency benefits that direct interrupts provide
* and one might as well use a regular interrupt anyway.
*/
#ifndef CONFIG_X86_KPTI
#define ARCH_IRQ_DIRECT_CONNECT(irq_p, priority_p, isr_p, flags_p) \ #define ARCH_IRQ_DIRECT_CONNECT(irq_p, priority_p, isr_p, flags_p) \
{ \ { \
NANO_CPU_INT_REGISTER(isr_p, irq_p, priority_p, -1, 0); \ NANO_CPU_INT_REGISTER(isr_p, irq_p, priority_p, -1, 0); \
@ -305,6 +313,7 @@ static inline void arch_isr_direct_footer(int swap)
ISR_DIRECT_FOOTER(check_reschedule); \ ISR_DIRECT_FOOTER(check_reschedule); \
} \ } \
static inline int name##_body(void) static inline int name##_body(void)
#endif /* !CONFIG_X86_KPTI */
/** /**
* @brief Exception Stack Frame * @brief Exception Stack Frame