michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Add comment clarifying condition check in bt_le_adv_start

Browse source 
It is valid to call set_ad with NULL data as long as length is 0.
Improve code comment for unusual condition check explaning why it
is correct.

Change-Id: I29440fb04747f6df06dc4df466eb43e160ff3be4
Signed-off-by: Szymon Janc <ext.szymon.janc@tieto.com>
This commit is contained in:
Szymon Janc 2016-05-12 10:13:52 +02:00 • committed by Johan Hedberg
commit 32da5e6748
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
net/bluetooth/hci_core.c
View file

@ -3338,8 +3338,14 @@ int bt_le_adv_start(const struct bt_le_adv_param *param,
return err;
}
/* make sure we clear old SCAN_RSP if it will be used but wasn't
* provided.
/*
* We need to set SCAN_RSP when enabling advertising type that allows
* for Scan Requests.
*
* If sd was not provided but we enable connectable undirected
* advertising sd needs to be cleared from values set by previous calls.
* Clearing sd is done by calling set_ad() with NULL data and zero len.
* So following condition check is unusual but correct.
*/
if (sd || (param->options & BT_LE_ADV_OPT_CONNECTABLE)) {
err = set_ad(BT_HCI_OP_LE_SET_SCAN_RSP_DATA, sd, sd_len);