michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: sensor: si7060: fix: insecure data handling caught by coverity

Browse source 
- Checking each retval from read register before continue

Signed-off-by: Fabian Barraez <fabianbarraez@gmail.com>
This commit is contained in:
Fabian Barraez 2025-02-22 12:03:42 -05:00 • committed by Benjamin Cabé
commit 3295f7c5e2
1 changed files with 12 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

19
drivers/sensor/silabs/si7060/si7060.c
View file

@ -58,15 +58,20 @@ static int si7060_sample_fetch(const struct device *dev,
uint8_t dspsigl;
retval = si7060_reg_read(dev, SI7060_REG_TEMP_HIGH, &dspsigm);
retval += si7060_reg_read(dev, SI7060_REG_TEMP_LOW, &dspsigl);
if (retval == 0) {
drv_data->temperature = (256 * (dspsigm & SIGN_BIT_MASK))
+ dspsigl;
} else {
LOG_ERR("Read register err");
if (retval != 0) {
LOG_ERR("Error reading temperature high register");
return retval;
}
retval = si7060_reg_read(dev, SI7060_REG_TEMP_LOW, &dspsigl);
if (retval != 0) {
LOG_ERR("Error reading temperature low register");
return retval;
}
drv_data->temperature = (256 * (dspsigm & SIGN_BIT_MASK))
+ dspsigl;
LOG_DBG("Sample_fetch retval: %d", retval);
return retval;