michaelh/zephyr
1
0
Fork 0
Code Releases Activity

subsys: kernel_event_logger: change kernel event values

Browse source 
Each bit of "_sys_k_event_logger_mask" corresponds to a
kernel event type. Hence KERNEL_EVENT_TYPE values should be
power of 2. Previous implementation was not adhering
to it ,because of which "sys_k_must_log_event" and
"sys_k_event_logger_set_mask" had unintended effects when
used to mask certain kernel events.

Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
This commit is contained in:
Savinay Dharmappa 2018-02-21 00:07:48 +05:30 • committed by Anas Nashif
commit 31a4e1ccf4
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
include/logging/kernel_event_logger.h
View file

@ -20,10 +20,10 @@ extern "C" {
/* predefined event types */ /* predefined event types */
#define KERNEL_EVENT_LOGGER_CONTEXT_SWITCH_EVENT_ID 0x0001 #define KERNEL_EVENT_LOGGER_CONTEXT_SWITCH_EVENT_ID BIT(0)
#define KERNEL_EVENT_LOGGER_INTERRUPT_EVENT_ID 0x0002 #define KERNEL_EVENT_LOGGER_INTERRUPT_EVENT_ID BIT(1)
#define KERNEL_EVENT_LOGGER_SLEEP_EVENT_ID 0x0003 #define KERNEL_EVENT_LOGGER_SLEEP_EVENT_ID BIT(2)
#define KERNEL_EVENT_LOGGER_THREAD_EVENT_ID 0x0004 #define KERNEL_EVENT_LOGGER_THREAD_EVENT_ID BIT(3)
#ifndef _ASMLANGUAGE #ifndef _ASMLANGUAGE
@ -174,7 +174,7 @@ static inline int sys_k_event_logger_get_mask(void)
static inline int sys_k_must_log_event(int event_type) static inline int sys_k_must_log_event(int event_type)
{ {
#ifdef CONFIG_KERNEL_EVENT_LOGGER_DYNAMIC #ifdef CONFIG_KERNEL_EVENT_LOGGER_DYNAMIC
return !!(_sys_k_event_logger_mask & (1 << (event_type - 1))); return !!(_sys_k_event_logger_mask & event_type);
#else #else
ARG_UNUSED(event_type); ARG_UNUSED(event_type);