michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: regulator: move I2C reg reads to regulator_read_register

Browse source 
Move I2C register reads to regulator_read_register in regulator driver,
to enable better abstraction of regulator I2C reads

Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
This commit is contained in:
Daniel DeGrasse 2022-08-30 13:04:56 -05:00 • committed by Carles Cufí
commit 30d71d5457
1 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
drivers/regulator/regulator_pmic.c
View file

@ -58,6 +58,16 @@ struct regulator_config {
uint32_t *current_array; uint32_t *current_array;
}; };
/**
* Reads a register from the PMIC
* Returns 0 on success, or errno on error
*/
static int regulator_read_register(const struct regulator_config *conf,
uint8_t reg, uint8_t *out)
{
return i2c_reg_read_byte_dt(&conf->i2c, reg, out);
}
/** /**
* Modifies a register within the PMIC * Modifies a register within the PMIC
* Returns 0 on success, or errno on error * Returns 0 on success, or errno on error
@ -68,7 +78,7 @@ static int regulator_modify_register(const struct regulator_config *conf,
uint8_t reg_current; uint8_t reg_current;
int rc; int rc;
rc = i2c_reg_read_byte_dt(&conf->i2c, reg, &reg_current); rc = regulator_read_register(conf, reg, &reg_current);
if (rc) { if (rc) {
return rc; return rc;
} }
@ -162,7 +172,7 @@ int regulator_get_voltage(const struct device *dev)
int rc, i = 0; int rc, i = 0;
uint8_t raw_reg; uint8_t raw_reg;
rc = i2c_reg_read_byte_dt(&config->i2c, config->vsel_reg, &raw_reg); rc = regulator_read_register(config, config->vsel_reg, &raw_reg);
if (rc) { if (rc) {
return rc; return rc;
} }
@ -221,7 +231,7 @@ int regulator_get_current_limit(const struct device *dev)
if (config->num_current_levels == 0) { if (config->num_current_levels == 0) {
return -ENOTSUP; return -ENOTSUP;
} }
rc = i2c_reg_read_byte_dt(&config->i2c, config->ilim_reg, &raw_reg); rc = regulator_read_register(config, config->ilim_reg, &raw_reg);
if (rc) { if (rc) {
return rc; return rc;
} }