From 306dba1d917ebe8ace4979c89a62b3032a542801 Mon Sep 17 00:00:00 2001 From: Lukasz Mrugala Date: Fri, 9 Aug 2024 13:14:42 +0000 Subject: [PATCH] scripts: twister: Elevate status errors Incorrect status assignments were previously just warnings in logs. Now they are elevated to errors. Signed-off-by: Lukasz Mrugala --- scripts/pylib/twister/twisterlib/harness.py | 2 +- scripts/pylib/twister/twisterlib/testinstance.py | 2 +- scripts/pylib/twister/twisterlib/testsuite.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/pylib/twister/twisterlib/harness.py b/scripts/pylib/twister/twisterlib/harness.py index eb507d2f86b..751f455d658 100644 --- a/scripts/pylib/twister/twisterlib/harness.py +++ b/scripts/pylib/twister/twisterlib/harness.py @@ -75,7 +75,7 @@ class Harness: key = value.name if isinstance(value, Enum) else value self._status = TwisterStatus[key] except KeyError: - logger.warning(f'Harness assigned status "{value}"' + logger.error(f'Harness assigned status "{value}"' f' without an equivalent in TwisterStatus.' f' Assignment was ignored.') diff --git a/scripts/pylib/twister/twisterlib/testinstance.py b/scripts/pylib/twister/twisterlib/testinstance.py index d5f85017949..6ababf62d0c 100644 --- a/scripts/pylib/twister/twisterlib/testinstance.py +++ b/scripts/pylib/twister/twisterlib/testinstance.py @@ -105,7 +105,7 @@ class TestInstance: key = value.name if isinstance(value, Enum) else value self._status = TwisterStatus[key] except KeyError: - logger.warning(f'TestInstance assigned status "{value}"' + logger.error(f'TestInstance assigned status "{value}"' f' without an equivalent in TwisterStatus.' f' Assignment was ignored.') diff --git a/scripts/pylib/twister/twisterlib/testsuite.py b/scripts/pylib/twister/twisterlib/testsuite.py index 51e6ac7327f..5759aa94999 100644 --- a/scripts/pylib/twister/twisterlib/testsuite.py +++ b/scripts/pylib/twister/twisterlib/testsuite.py @@ -377,7 +377,7 @@ class TestCase(DisablePyTestCollectionMixin): key = value.name if isinstance(value, Enum) else value self._status = TwisterStatus[key] except KeyError: - logger.warning(f'TestCase assigned status "{value}"' + logger.error(f'TestCase assigned status "{value}"' f' without an equivalent in TwisterStatus.' f' Assignment was ignored.') @@ -445,7 +445,7 @@ class TestSuite(DisablePyTestCollectionMixin): key = value.name if isinstance(value, Enum) else value self._status = TwisterStatus[key] except KeyError: - logger.warning(f'TestSuite assigned status "{value}"' + logger.error(f'TestSuite assigned status "{value}"' f' without an equivalent in TwisterStatus.' f' Assignment was ignored.')