michaelh/zephyr
1
0
Fork 0
Code Releases Activity

arch: x86: Unwind the stack on fatal errors

Browse source 
Prints up to 8 stack frames, with the following format:
  RETURN_ADDR(ARGUMENTS)

Signed-off-by: Leandro Pereira <leandro.pereira@intel.com>
This commit is contained in:
Leandro Pereira 2018-01-29 12:51:13 -08:00 • committed by Andrew Boie
commit 2f5659d4d2
2 changed files with 61 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

52
arch/x86/core/fatal.c
View file

@ -24,6 +24,44 @@
__weak void _debug_fatal_hook(const NANO_ESF *esf) { ARG_UNUSED(esf); }
#if defined(CONFIG_EXCEPTION_STACK_TRACE)
struct stack_frame {
u32_t next;
u32_t ret_addr;
u32_t args;
};
#define MAX_STACK_FRAMES 8
static void unwind_stack(u32_t base_ptr)
{
struct stack_frame *frame;
int i;
if (!base_ptr) {
printk("NULL base ptr\n");
return;
}
for (i = 0; i < MAX_STACK_FRAMES; i++) {
if (base_ptr % sizeof(base_ptr) != 0) {
printk("unaligned frame ptr\n");
return;
}
frame = (struct stack_frame *)base_ptr;
if (!frame || !frame->ret_addr) {
break;
}
#ifdef CONFIG_X86_IAMCU
printk(" 0x%08x\n", frame->ret_addr);
#else
printk(" 0x%08x (0x%x)\n", frame->ret_addr, frame->args);
#endif
base_ptr = frame->next;
}
}
#endif /* CONFIG_EXCEPTION_STACK_TRACE */
/**
*
@ -90,15 +128,21 @@ FUNC_NORETURN void _NanoFatalErrorHandler(unsigned int reason,
}
printk("Current thread ID = %p\n"
"Faulting segment:address = 0x%04x:0x%08x\n"
"eax: 0x%08x, ebx: 0x%08x, ecx: 0x%08x, edx: 0x%08x\n"
"esi: 0x%08x, edi: 0x%08x, ebp: 0x%08x, esp: 0x%08x\n"
"eflags: 0x%x\n",
"eflags: 0x%08x cs: 0x%04x\n"
#ifdef CONFIG_EXCEPTION_STACK_TRACE
"call trace:\n"
#endif
"eip: 0x%08x\n",
k_current_get(),
pEsf->cs & 0xFFFF, pEsf->eip,
pEsf->eax, pEsf->ebx, pEsf->ecx, pEsf->edx,
pEsf->esi, pEsf->edi, pEsf->ebp, pEsf->esp,
pEsf->eflags);
pEsf->eflags, pEsf->cs & 0xFFFF, pEsf->eip);
#ifdef CONFIG_EXCEPTION_STACK_TRACE
unwind_stack(pEsf->ebp);
#endif
#endif /* CONFIG_PRINTK */

17
subsys/debug/Kconfig
View file

@ -163,12 +163,21 @@ config OMIT_FRAME_POINTER
config DEBUG_INFO
bool "Enable system debugging information"
default n
depends on X86
help
This option enables the addition of various information that can be used
by debuggers in debugging the system.
This option enables the addition of various information that can be
used by debuggers in debugging the system, or enable additional
debugging information to be reported at runtime.
NOTE: Does not currently work with the x86 IAMCU ABI.
config EXCEPTION_STACK_TRACE
bool "Attempt to print stack traces upon exceptions"
default y
depends on PRINTK
depends on DEBUG_INFO
depends on !OMIT_FRAME_POINTER
help
If the architecture fatal handling code supports it, attempt to
print a stack trace of function memory addresses when an
exception is reported.
#
# Miscellaneous debugging options