michaelh/zephyr
1
0
Fork 0
Code Releases Activity

testsuite: support reboot to retry intermittent tests

Browse source 
When a test fails intermittently there is currently no alternative to
looking at logs and pressing a hardware reset button.  This commit
adds a Kconfig option that can be set when diagnosing an intermittent
failure.  The behavior is to do a cold reset of the board when the
test passes.  A counter is maintained in noinit memory to track the
number of times it takes to reproduce a failure.

Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
This commit is contained in:
Peter Bigot 2019-09-07 10:26:13 -05:00 • committed by Anas Nashif
commit 2dfbf21410
2 changed files with 31 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
subsys/testsuite/ztest/Kconfig
View file

@ -49,6 +49,14 @@ config ZTEST_TC_UTIL_USER_OVERRIDE
The override header may now #define the various macros and strings in tc_util.h which are
surrounded by #ifndef ... #endif blocks.
config ZTEST_RETEST_IF_PASSED
bool "Reset the board to test again if the test passed"
select REBOOT
help
If the test passed reset the board so it is run again. This
may be used as an alternative to manual resets when
attempting to reproduce an intermittent failure.
endif # ZTEST
config ZTEST_MOCKING

23
subsys/testsuite/ztest/src/ztest.c
View file

@ -10,6 +10,7 @@
#ifdef CONFIG_USERSPACE
#include <sys/libc-hooks.h>
#endif
#include <power/reboot.h>
#ifdef KERNEL
static struct k_thread ztest_thread;
@ -323,5 +324,27 @@ void main(void)
z_init_mock();
test_main();
end_report();
if (IS_ENABLED(CONFIG_ZTEST_RETEST_IF_PASSED)) {
static __noinit struct {
u32_t magic;
u32_t boots;
} state;
const u32_t magic = 0x152ac523;
if (state.magic != magic) {
state.magic = magic;
state.boots = 0;
}
state.boots += 1;
if (test_status == 0) {
PRINT("Reset board #%u to test again\n",
state.boots);
k_sleep(K_MSEC(10));
sys_reboot(SYS_REBOOT_COLD);
} else {
PRINT("Failed after %u attempts\n", state.boots);
state.boots = 0;
}
}
}
#endif