michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kconfig: Remove symbol types from Kconfig.defconfig files

Browse source 
Same deal as in commit 7fdb525754 ("kconfig: Use 'default' instead of
'def_bool' in Kconfig.defconfig files"), but I hacked Kconfiglib to also
find cases where the type is given separately as e.g.

    config FOO
            int
            default 3

Motivation (from a note in
https://docs.zephyrproject.org/latest/guides/kconfig/index.html):

    For a symbol defined in multiple locations (e.g., in a
    Kconfig.defconfig file in Zephyr), it is best to only give the
    symbol type for the "base" definition of the symbol, and to use
    'default' (instead of 'def_<type>' value) for the remaining
    definitions. That way, if the base definition of the symbol is
    removed, the symbol ends up without a type, which generates a
    warning that points to the other definitions. That makes the extra
    definitions easier to discover and remove.

It's also nice if 'def_bool' and the like turn into a semi-reliable flag
that the symbol is only defined in Kconfig.defconfig files. That might
be a sign that things could be cleaned up.

Will do a separate pass later to remove some symbols only defined in
Kconfig.defconfig files.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2019-10-24 08:13:13 +02:00 • committed by Maureen Helm
commit 2b61031c8f
134 changed files with 27 additions and 197 deletions
Download patch file Download diff file Expand all files Collapse all files

15
soc/riscv/openisa_rv32m1/Kconfig.defconfig
View file

@ -7,7 +7,6 @@
if SOC_OPENISA_RV32M1_RISCV32
config SOC
string
default "openisa_rv32m1"
# 32 from event unit + 32 * (1 + max enabled INTMUX channel)
@ -24,24 +23,19 @@ config NUM_IRQS
default 32
config XIP
bool
default y
config RISCV_GENERIC_TOOLCHAIN
bool
default y if "$(ZEPHYR_TOOLCHAIN_VARIANT)" = "zephyr"
default n
config RISCV_SOC_CONTEXT_SAVE
bool
default y if SOC_OPENISA_RV32M1_RI5CY
config RISCV_SOC_OFFSETS
bool
default y
config RISCV_SOC_INTERRUPT_INIT
bool
default y
# We need to disable the watchdog out of reset, as it's enabled by
@ -61,24 +55,20 @@ config RISCV_RV32M1_VECTOR_SIZE
default 0x100
config SYS_CLOCK_HW_CYCLES_PER_SEC
int
default 8000000
if MULTI_LEVEL_INTERRUPTS
config MAX_IRQ_PER_AGGREGATOR
int
default 32
config 2ND_LEVEL_INTERRUPTS
default y
config 2ND_LVL_ISR_TBL_OFFSET
int
default 32
config NUM_2ND_LEVEL_AGGREGATORS
int
default 8 if RV32M1_INTMUX_CHANNEL_7
default 7 if RV32M1_INTMUX_CHANNEL_6
default 6 if RV32M1_INTMUX_CHANNEL_5
@ -89,7 +79,6 @@ config NUM_2ND_LEVEL_AGGREGATORS
default 1 # just channel 0
config 2ND_LVL_INTR_00_OFFSET
int
default 24
config 2ND_LVL_INTR_01_OFFSET
@ -162,14 +151,14 @@ endif # GPIO
if SERIAL
config UART_RV32M1_LPUART
def_bool y
default y
endif # SERIAL
if I2C
config I2C_RV32M1_LPI2C
def_bool y
default y
endif # I2C