michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kconfig: Remove symbol types from Kconfig.defconfig files

Browse source 
Same deal as in commit 7fdb525754 ("kconfig: Use 'default' instead of
'def_bool' in Kconfig.defconfig files"), but I hacked Kconfiglib to also
find cases where the type is given separately as e.g.

    config FOO
            int
            default 3

Motivation (from a note in
https://docs.zephyrproject.org/latest/guides/kconfig/index.html):

    For a symbol defined in multiple locations (e.g., in a
    Kconfig.defconfig file in Zephyr), it is best to only give the
    symbol type for the "base" definition of the symbol, and to use
    'default' (instead of 'def_<type>' value) for the remaining
    definitions. That way, if the base definition of the symbol is
    removed, the symbol ends up without a type, which generates a
    warning that points to the other definitions. That makes the extra
    definitions easier to discover and remove.

It's also nice if 'def_bool' and the like turn into a semi-reliable flag
that the symbol is only defined in Kconfig.defconfig files. That might
be a sign that things could be cleaned up.

Will do a separate pass later to remove some symbols only defined in
Kconfig.defconfig files.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2019-10-24 08:13:13 +02:00 • committed by Maureen Helm
commit 2b61031c8f
134 changed files with 27 additions and 197 deletions
Download patch file Download diff file Expand all files Collapse all files

1
soc/arm/nxp_imx/mcimx6x_m4/Kconfig.defconfig.mcimx6x_m4
View file

@ -8,7 +8,6 @@
if SOC_MCIMX6X_M4
config SOC
string
default "mcimx6x"
config FLOAT

2
soc/arm/nxp_imx/mcimx7_m4/Kconfig.defconfig.mcimx7_m4
View file

@ -8,11 +8,9 @@
if SOC_MCIMX7_M4
config SOC
string
default "mcimx7d"
config SYS_CLOCK_HW_CYCLES_PER_SEC
int
default 200000000
if CLOCK_CONTROL

1
soc/arm/nxp_imx/rt/Kconfig.defconfig.mimxrt1015
View file

@ -8,7 +8,6 @@
if SOC_MIMXRT1015
config SOC
string
default "mimxrt1015"
config NUM_IRQS

1
soc/arm/nxp_imx/rt/Kconfig.defconfig.mimxrt1021
View file

@ -8,7 +8,6 @@
if SOC_MIMXRT1021
config SOC
string
default "mimxrt1021"
config NUM_IRQS

1
soc/arm/nxp_imx/rt/Kconfig.defconfig.mimxrt1052
View file

@ -8,7 +8,6 @@
if SOC_MIMXRT1052
config SOC
string
default "mimxrt1052"
config NUM_IRQS

1
soc/arm/nxp_imx/rt/Kconfig.defconfig.mimxrt1062
View file

@ -8,7 +8,6 @@
if SOC_MIMXRT1062
config SOC
string
default "mimxrt1062"
config NUM_IRQS

1
soc/arm/nxp_imx/rt/Kconfig.defconfig.mimxrt1064
View file

@ -8,7 +8,6 @@
if SOC_MIMXRT1064
config SOC
string
default "mimxrt1064"
config NUM_IRQS