From 2abfccb352fe0f6369a94be5234817ff72a8187c Mon Sep 17 00:00:00 2001 From: Flavio Ceolin Date: Wed, 22 Jan 2020 14:15:18 -0800 Subject: [PATCH] driver: uart: ns16550: Simplify drv_cmd function There is only one possible command, so just use if instead of switch to avoid several MISRA-C violations and also avoid set dev_data wrongly unused when UART_NS16550_DLF_ENABLED is defined. Signed-off-by: Flavio Ceolin --- drivers/serial/uart_ns16550.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/serial/uart_ns16550.c b/drivers/serial/uart_ns16550.c index 89ad9162482..605d867fc95 100644 --- a/drivers/serial/uart_ns16550.c +++ b/drivers/serial/uart_ns16550.c @@ -793,20 +793,14 @@ static int uart_ns16550_line_ctrl_set(struct device *dev, */ static int uart_ns16550_drv_cmd(struct device *dev, u32_t cmd, u32_t p) { - struct uart_ns16550_dev_data_t * const dev_data = DEV_DATA(dev); - - ARG_UNUSED(dev_data); - - switch (cmd) { - #ifdef UART_NS16550_DLF_ENABLED - case CMD_SET_DLF: + if (cmd == CMD_SET_DLF) { + struct uart_ns16550_dev_data_t * const dev_data = DEV_DATA(dev); dev_data->dlf = p; OUTBYTE(DLF(dev), dev_data->dlf); return 0; -#endif - } +#endif return -ENOTSUP; }