michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: sensors: Consistently quote "GPIO_0" string default

Browse source 
These cases weren't caught by the heuristic used by the warning added in
commit 6eabea3a7e ("Kconfiglib: Warn for unquoted string defaults"),
because "GPIO_0" has no lowercase characters in it.

Unquoted Kconfig values are are indistinguishable from reference to
(undefined) symbols in general. Quoting all string defaults will help
find "true" references to undefined Kconfig symbols, and makes it
clearer that the value is constant.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2018-06-01 05:43:24 +02:00 • committed by Anas Nashif
commit 2a8349950e
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/sensor/bmc150_magn/Kconfig
View file

@ -112,7 +112,7 @@ config BMC150_MAGN_TRIGGER_DRDY
config BMC150_MAGN_GPIO_DRDY_DEV_NAME config BMC150_MAGN_GPIO_DRDY_DEV_NAME
string "GPIO device where BMC150_MAGN data ready interrupt is connected" string "GPIO device where BMC150_MAGN data ready interrupt is connected"
depends on BMC150_MAGN_TRIGGER_DRDY depends on BMC150_MAGN_TRIGGER_DRDY
default GPIO_0 default "GPIO_0"
help help
Specify the device name of the GPIO controller the BMC150_MAGN interrupt Specify the device name of the GPIO controller the BMC150_MAGN interrupt
is connected to. is connected to.

2
drivers/sensor/lsm9ds0_gyro/Kconfig
View file

@ -122,7 +122,7 @@ config LSM9DS0_GYRO_TRIGGER_DRDY
config LSM9DS0_GYRO_GPIO_DRDY_DEV_NAME config LSM9DS0_GYRO_GPIO_DRDY_DEV_NAME
string "GPIO device where LSM9DS0_GYRO data ready interrupt is connected" string "GPIO device where LSM9DS0_GYRO data ready interrupt is connected"
depends on LSM9DS0_GYRO_TRIGGER_DRDY depends on LSM9DS0_GYRO_TRIGGER_DRDY
default GPIO_0 default "GPIO_0"
help help
Specify the device name of the GPIO controller the BMC150_MAGN interrupt Specify the device name of the GPIO controller the BMC150_MAGN interrupt
is connected to. is connected to.

2
drivers/sensor/sx9500/Kconfig
View file

@ -69,7 +69,7 @@ config SX9500_TRIGGER
config SX9500_GPIO_CONTROLLER config SX9500_GPIO_CONTROLLER
string "GPIO controller for SX9500 interrupt" string "GPIO controller for SX9500 interrupt"
depends on SX9500 && SX9500_TRIGGER depends on SX9500 && SX9500_TRIGGER
default GPIO_0 default "GPIO_0"
help help
Specify the device name of the GPIO controller the SX9500 interrupt Specify the device name of the GPIO controller the SX9500 interrupt
is connected to. is connected to.