michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: modem: gsm: Customize error logs to ease debugging

Browse source 
Customize the error logs in each connection finalization steps
so that it is easier to trace the error.

Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
This commit is contained in:
Yong Cong Sin 2021-09-16 19:20:37 +08:00 • committed by Carles Cufí
commit 2984a9c322
1 changed files with 7 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

21
drivers/modem/gsm_ppp.c
View file

@ -620,10 +620,8 @@ static void gsm_finalize_connection(struct gsm_modem *gsm)
"AT", &gsm->sem_response, "AT", &gsm->sem_response,
GSM_CMD_AT_TIMEOUT); GSM_CMD_AT_TIMEOUT);
if (ret < 0) { if (ret < 0) {
LOG_ERR("modem setup returned %d, %s", LOG_ERR("%s returned %d, %s", "AT", ret, "retrying...");
ret, "retrying..."); (void)gsm_work_reschedule(&gsm->gsm_configure_work, K_SECONDS(1));
(void)gsm_work_reschedule(&gsm->gsm_configure_work,
K_SECONDS(1));
return; return;
} }
} }
@ -639,10 +637,8 @@ static void gsm_finalize_connection(struct gsm_modem *gsm)
} }
ret = gsm_setup_mccmno(gsm); ret = gsm_setup_mccmno(gsm);
if (ret < 0) { if (ret < 0) {
LOG_ERR("modem setup returned %d, %s", LOG_ERR("%s returned %d, %s", "gsm_setup_mccmno", ret, "retrying...");
ret, "retrying...");
(void)gsm_work_reschedule(&gsm->gsm_configure_work, (void)gsm_work_reschedule(&gsm->gsm_configure_work,
K_SECONDS(1)); K_SECONDS(1));
@ -656,8 +652,7 @@ static void gsm_finalize_connection(struct gsm_modem *gsm)
&gsm->sem_response, &gsm->sem_response,
GSM_CMD_SETUP_TIMEOUT); GSM_CMD_SETUP_TIMEOUT);
if (ret < 0) { if (ret < 0) {
LOG_DBG("modem setup returned %d, %s", LOG_DBG("%s returned %d, %s", "setup_cmds", ret, "retrying...");
ret, "retrying...");
(void)gsm_work_reschedule(&gsm->gsm_configure_work, K_SECONDS(1)); (void)gsm_work_reschedule(&gsm->gsm_configure_work, K_SECONDS(1));
return; return;
} }
@ -725,7 +720,7 @@ attaching:
#endif #endif
} }
LOG_DBG("modem setup returned %d, %s", ret, "enable PPP"); LOG_DBG("modem RSSI: %d, %s", *gsm->context.data_rssi, "enable PPP");
ret = modem_cmd_handler_setup_cmds_nolock(&gsm->context.iface, ret = modem_cmd_handler_setup_cmds_nolock(&gsm->context.iface,
&gsm->context.cmd_handler, &gsm->context.cmd_handler,
@ -734,8 +729,7 @@ attaching:
&gsm->sem_response, &gsm->sem_response,
GSM_CMD_SETUP_TIMEOUT); GSM_CMD_SETUP_TIMEOUT);
if (ret < 0) { if (ret < 0) {
LOG_DBG("modem setup returned %d, %s", LOG_DBG("%s returned %d, %s", "connect_cmds", ret, "retrying...");
ret, "retrying...");
(void)gsm_work_reschedule(&gsm->gsm_configure_work, K_SECONDS(1)); (void)gsm_work_reschedule(&gsm->gsm_configure_work, K_SECONDS(1));
return; return;
} }
@ -758,8 +752,7 @@ attaching:
"AT", &gsm->sem_response, "AT", &gsm->sem_response,
GSM_CMD_AT_TIMEOUT); GSM_CMD_AT_TIMEOUT);
if (ret < 0) { if (ret < 0) {
LOG_WRN("modem setup returned %d, %s", LOG_WRN("%s returned %d, %s", "AT", ret, "iface failed");
ret, "AT cmds failed");
} else { } else {
LOG_INF("AT channel %d connected to %s", LOG_INF("AT channel %d connected to %s",
DLCI_AT, gsm->at_dev->name); DLCI_AT, gsm->at_dev->name);