michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: uart_native_posix: Check return values of system calls

Browse source 
Let's check the return values of all system calls
to ensure they do not error, or handle it gracefully
if they do.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
This commit is contained in:
Alberto Escolar Piedras 2023-06-01 16:39:05 +02:00 • committed by Anas Nashif
commit 294ccc1cb8
1 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

28
drivers/serial/uart_native_posix.c
View file

@ -197,7 +197,18 @@ static int open_tty(struct native_uart_status *driver_data,
* The connection of the client would cause the HUP flag to be
* cleared, and in turn set again at disconnect.
*/
close(open(slave_pty_name, O_RDWR | O_NOCTTY));
ret = open(slave_pty_name, O_RDWR | O_NOCTTY);
if (ret == -1) {
err_nbr = errno;
ERROR("%s: Could not open terminal from the slave side (%i,%s)\n",
__func__, err_nbr, strerror(err_nbr));
}
ret = close(ret);
if (ret == -1) {
err_nbr = errno;
ERROR("%s: Could not close terminal from the slave side (%i,%s)\n",
__func__, err_nbr, strerror(err_nbr));
}
}
if (do_auto_attach) {
attach_to_tty(slave_pty_name);
@ -281,7 +292,20 @@ static void np_uart_poll_out(const struct device *dev,
struct pollfd pfd = { .fd = d->out_fd, .events = POLLHUP };
while (1) {
poll(&pfd, 1, 0);
ret = poll(&pfd, 1, 0);
if (ret == -1) {
int err = errno;
/*
* Possible errors are:
* * EINTR :A signal was received => ok
* * EFAULT and EINVAL: parameters/programming error
* * ENOMEM no RAM left
*/
if (err != EINTR) {
ERROR("%s: unexpected error during poll, errno=%i,%s\n",
__func__, err, strerror(err));
}
}
if (!(pfd.revents & POLLHUP)) {
/* There is now a reader on the slave side */
break;