michaelh/zephyr
1
0
Fork 0
Code Releases Activity

mgmt/MCUmgr/mgmt: Support for finding registered command groups

Browse source 
This commit adds support for finding registered mcumgr command groups.

By default, supported command groups are local to the namespace where
they're registered. This api addition allows applications to get
reference to these supported command groups to deregister & re-register
them.

This adds scope for applications to support multiple implementations
of a command group alongside the default.

Signed-off-by: Chandler Keep <chandlersamkeep@gmail.com>
This commit is contained in:
Chandler Keep 2023-09-28 10:00:55 +01:00 • committed by Carles Cufí
commit 27b4b9f4c8
2 changed files with 33 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
include/zephyr/mgmt/mcumgr/mgmt/mgmt.h
View file

@ -123,6 +123,16 @@ void mgmt_unregister_group(struct mgmt_group *group);
*/ */
const struct mgmt_handler *mgmt_find_handler(uint16_t group_id, uint16_t command_id); const struct mgmt_handler *mgmt_find_handler(uint16_t group_id, uint16_t command_id);
/**
* @brief Finds a registered command group.
*
* @param group_id The command group id to find.
*
* @return The requested command group on success;
* NULL on failure.
*/
const struct mgmt_group *mgmt_find_group(uint16_t group_id);
#if IS_ENABLED(CONFIG_MCUMGR_SMP_SUPPORT_ORIGINAL_PROTOCOL) #if IS_ENABLED(CONFIG_MCUMGR_SMP_SUPPORT_ORIGINAL_PROTOCOL)
/** /**
* @brief Finds a registered error translation function for converting from SMP * @brief Finds a registered error translation function for converting from SMP

23
subsys/mgmt/mcumgr/mgmt/src/mgmt.c
View file

@ -69,6 +69,29 @@ mgmt_find_handler(uint16_t group_id, uint16_t command_id)
return &group->mg_handlers[command_id]; return &group->mg_handlers[command_id];
} }
const struct mgmt_group *
mgmt_find_group(uint16_t group_id)
{
struct mgmt_group *group = NULL;
sys_snode_t *snp, *sns;
/*
* Find the group with the specified group id
* from the registered group list, if one exists
* return the matching mgmt group pointer, otherwise return NULL
*/
SYS_SLIST_FOR_EACH_NODE_SAFE(&mgmt_group_list, snp, sns) {
struct mgmt_group *loop_group =
CONTAINER_OF(snp, struct mgmt_group, node);
if (loop_group->mg_group_id == group_id) {
group = loop_group;
break;
}
}
return group;
}
#if IS_ENABLED(CONFIG_MCUMGR_SMP_SUPPORT_ORIGINAL_PROTOCOL) #if IS_ENABLED(CONFIG_MCUMGR_SMP_SUPPORT_ORIGINAL_PROTOCOL)
smp_translate_error_fn mgmt_find_error_translation_function(uint16_t group_id) smp_translate_error_fn mgmt_find_error_translation_function(uint16_t group_id)
{ {