michaelh/zephyr
1
0
Fork 0
Code Releases Activity

scripts: gitlint: Consistent case for Signed-off-by

Browse source 
The commit header as added by "git commit -s" is "Signed-off-by:",
and not any other casing. While it perhaps case-insensitive, use
canonical casing to not confuse (attentive) users.

Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
This commit is contained in:
Paul Sokolovsky 2019-02-18 19:52:59 +03:00 • committed by Anas Nashif
commit 26e562c0bd
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
scripts/gitlint/zephyr_commit_rules.py
View file

@ -51,8 +51,8 @@ class BodyMaxLineCount(CommitRule):
return [RuleViolation(self.id, message, line_nr=1)] return [RuleViolation(self.id, message, line_nr=1)]
class SignedOffBy(CommitRule): class SignedOffBy(CommitRule):
""" This rule will enforce that each commit contains a "Signed-Off-By" line. """ This rule will enforce that each commit contains a "Signed-off-by" line.
We keep things simple here and just check whether the commit body contains a line that starts with "Signed-Off-By". We keep things simple here and just check whether the commit body contains a line that starts with "Signed-off-by".
""" """
# A rule MUST have a human friendly name # A rule MUST have a human friendly name
@ -70,7 +70,7 @@ class SignedOffBy(CommitRule):
return [RuleViolation(self.id, "Signed-off-by: must have a full name", line_nr=1)] return [RuleViolation(self.id, "Signed-off-by: must have a full name", line_nr=1)]
else: else:
return return
return [RuleViolation(self.id, "Body does not contain a 'Signed-Off-By' line", line_nr=1)] return [RuleViolation(self.id, "Body does not contain a 'Signed-off-by:' line", line_nr=1)]
class TitleMaxLengthRevert(LineRule): class TitleMaxLengthRevert(LineRule):
name = "title-max-length-no-revert" name = "title-max-length-no-revert"