michaelh/zephyr
1
0
Fork 0
Code Releases Activity

soc: intel_adsp: Unify "active CPUs" state

Browse source 
This feature got written twice for two different purposes (to inform
the SOF app of which CPUs are running, and to predicate the delivery
of IPIs to the cores ready to receive the interrupt).  Use only one.

Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
This commit is contained in:
Andy Ross 2021-09-01 16:26:57 -07:00 • committed by Anas Nashif
commit 24cfa1415b
1 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
soc/xtensa/intel_adsp/common/soc_mp.c
View file

@ -88,8 +88,6 @@ static __aligned(XCHAL_DCACHE_LINESIZE) union {
(*((volatile struct cpustart_rec *) \ (*((volatile struct cpustart_rec *) \
z_soc_uncached_ptr(&cpustart_mem.cpustart))) z_soc_uncached_ptr(&cpustart_mem.cpustart)))
static uint32_t cpu_mask;
/* Simple array of CPUs that are active and available for an IPI. The /* Simple array of CPUs that are active and available for an IPI. The
* IDC interrupt is ALSO used to bring a CPU out of reset, so we need * IDC interrupt is ALSO used to bring a CPU out of reset, so we need
* to be absolutely sure we don't try to IPI a CPU that isn't ready to * to be absolutely sure we don't try to IPI a CPU that isn't ready to
@ -276,7 +274,7 @@ void z_mp_entry(void)
bool arch_cpu_active(int cpu_num) bool arch_cpu_active(int cpu_num)
{ {
return !!(cpu_mask & BIT(cpu_num)); return cpus_active[cpu_num];
} }
static ALWAYS_INLINE uint32_t prid(void) static ALWAYS_INLINE uint32_t prid(void)
@ -381,12 +379,6 @@ void arch_start_cpu(int cpu_num, k_thread_stack_t *stack, int sz,
while (!start_rec.alive) while (!start_rec.alive)
; ;
/*
* No locking needed as long as CPUs can only be powered on by the main
* CPU and cannot be powered off
*/
cpu_mask |= BIT(cpu_num);
} }
void arch_sched_ipi(void) void arch_sched_ipi(void)