michaelh/zephyr
1
0
Fork 0
Code Releases Activity

samples: intel_s1000: Simplify code and fix pylint warning

Browse source 
Empty sequences in Python are falsy, so

    if len(config_file) != 0:

can be simplified to

    if config_file:

pylint warning:

    C1801: Do not use `len(SEQUENCE)` to determine if a sequence is
    empty (len-as-condition)

Simplify the code a bit with os.path.join(), which indirectly gets rid
of the warning. os.path.join('', 'foo') returns 'foo', so things work
out when os.path.basename() returns '' (no directory) as well.

I'm getting rid of pylint warnings for a CI check.

Also replace a '== None' with 'is None', which is more common.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2019-09-02 12:23:33 +02:00 • committed by Anas Nashif
commit 2481a12529
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
samples/boards/intel_s1000_crb/audio/audio.py
View file

@ -25,17 +25,14 @@ class Device:
When the script is run using sudo permission, the
manufacturer and product strings are printed
"""
config_file = os.path.dirname(__file__)
if len(config_file) != 0:
config_file += '/'
config_file += 'config.yml'
config_file = os.path.join(os.path.dirname(__file__), 'config.yml')
with open(config_file, 'r') as ymlfile:
config = yaml.safe_load(ymlfile)
self.name = config['general']['name']
self.usb_vid = config['usb']['vid']
self.usb_pid = config['usb']['pid']
self.hid_dev = hid.device()
if self.hid_dev == None:
if self.hid_dev is None:
print('Device not found')
else:
self.hid_dev.open(self.usb_vid, self.usb_pid)