michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: sensor: apds9306 fix unchecked return value coverity issue

Browse source 
check the return valeus of i2c_reg_write_byte_dt function and return
appropriate error code

Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
This commit is contained in:
Jilay Pandya 2024-12-06 19:02:11 +01:00 • committed by Benjamin Cabé
commit 2174ea0ac0
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
drivers/sensor/apds9306/apds9306.c
View file

@ -271,7 +271,10 @@ static int apds9306_sensor_setup(const struct device *dev)
/* Wait for the device to become ready after a possible power cycle. */ /* Wait for the device to become ready after a possible power cycle. */
now = k_uptime_get_32(); now = k_uptime_get_32();
do { do {
i2c_reg_read_byte_dt(&config->i2c, APDS9306_REGISTER_MAIN_STATUS, &temp); if (i2c_reg_read_byte_dt(&config->i2c, APDS9306_REGISTER_MAIN_STATUS, &temp)) {
LOG_ERR("Failed reading sensor status!");
return -EFAULT;
}
/* We wait 100 ms maximum for the device to become ready. */ /* We wait 100 ms maximum for the device to become ready. */
if ((k_uptime_get_32() - now) > 100) { if ((k_uptime_get_32() - now) > 100) {
@ -308,7 +311,10 @@ static int apds9306_sensor_setup(const struct device *dev)
/* Perform a dummy read to avoid bus errors after the reset. See */ /* Perform a dummy read to avoid bus errors after the reset. See */
/* https://lore.kernel.org/lkml/ab1d9746-4d23-efcc-0ee1-d2b8c634becd@tweaklogic.com/ */ /* https://lore.kernel.org/lkml/ab1d9746-4d23-efcc-0ee1-d2b8c634becd@tweaklogic.com/ */
i2c_reg_read_byte_dt(&config->i2c, APDS9306_REGISTER_PART_ID, &temp); if (i2c_reg_read_byte_dt(&config->i2c, APDS9306_REGISTER_PART_ID, &temp)) {
LOG_ERR("Failed reading chip id!");
return -EFAULT;
}
return 0; return 0;
} }