michaelh/zephyr
1
0
Fork 0
Code Releases Activity

power: device: deduplicate suspending code

Browse source 
Function to put devices in lower power mode were all implemented in the
same way. Deduplicate code there by implementing single function to
handle all cases.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
This commit is contained in:
Marcin Niestroj 2020-01-21 22:53:48 +01:00 • committed by Anas Nashif
commit 21409494d1
2 changed files with 37 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

7
include/device.h
View file

@ -361,6 +361,13 @@ __syscall struct device *device_get_binding(const char *name);
#endif /* CONFIG_DEVICE_POWER_MANAGEMENT */ #endif /* CONFIG_DEVICE_POWER_MANAGEMENT */
/**
* @brief Get name of device PM state
*
* @param state State id which name should be returned
*/
const char *device_pm_state_str(u32_t state);
/** /**
* @brief Indicate that the device is in the middle of a transaction * @brief Indicate that the device is in the middle of a transaction
* *

62
subsys/power/device.c
View file

@ -44,7 +44,25 @@ static int device_retval[MAX_PM_DEVICES];
static struct device *pm_device_list; static struct device *pm_device_list;
static int device_count; static int device_count;
int sys_pm_suspend_devices(void) const char *device_pm_state_str(u32_t state)
{
switch (state) {
case DEVICE_PM_ACTIVE_STATE:
return "active";
case DEVICE_PM_LOW_POWER_STATE:
return "low power";
case DEVICE_PM_SUSPEND_STATE:
return "suspend";
case DEVICE_PM_FORCE_SUSPEND_STATE:
return "force suspend";
case DEVICE_PM_OFF_STATE:
return "off";
default:
return "";
}
}
static int _sys_pm_devices(u32_t state)
{ {
for (int i = device_count - 1; i >= 0; i--) { for (int i = device_count - 1; i >= 0; i--) {
int idx = device_ordered_list[i]; int idx = device_ordered_list[i];
@ -53,11 +71,12 @@ int sys_pm_suspend_devices(void)
* and set the device states accordingly. * and set the device states accordingly.
*/ */
device_retval[i] = device_set_power_state(&pm_device_list[idx], device_retval[i] = device_set_power_state(&pm_device_list[idx],
DEVICE_PM_SUSPEND_STATE, state,
NULL, NULL); NULL, NULL);
if (device_retval[i]) { if (device_retval[i]) {
LOG_DBG("%s did not enter suspend state", LOG_DBG("%s did not enter %s state",
pm_device_list[idx].config->name); pm_device_list[idx].config->name,
device_pm_state_str(state));
return device_retval[i]; return device_retval[i];
} }
} }
@ -65,40 +84,19 @@ int sys_pm_suspend_devices(void)
return 0; return 0;
} }
int sys_pm_suspend_devices(void)
{
return _sys_pm_devices(DEVICE_PM_SUSPEND_STATE);
}
int sys_pm_low_power_devices(void) int sys_pm_low_power_devices(void)
{ {
for (int i = device_count - 1; i >= 0; i--) { return _sys_pm_devices(DEVICE_PM_LOW_POWER_STATE);
int idx = device_ordered_list[i];
device_retval[i] = device_set_power_state(&pm_device_list[idx],
DEVICE_PM_LOW_POWER_STATE,
NULL, NULL);
if (device_retval[i]) {
LOG_DBG("%s did not enter low power state",
pm_device_list[idx].config->name);
return device_retval[i];
}
}
return 0;
} }
int sys_pm_force_suspend_devices(void) int sys_pm_force_suspend_devices(void)
{ {
for (int i = device_count - 1; i >= 0; i--) { return _sys_pm_devices(DEVICE_PM_FORCE_SUSPEND_STATE);
int idx = device_ordered_list[i];
device_retval[i] = device_set_power_state(&pm_device_list[idx],
DEVICE_PM_FORCE_SUSPEND_STATE,
NULL, NULL);
if (device_retval[i]) {
LOG_ERR("%s force suspend operation failed",
pm_device_list[idx].config->name);
return device_retval[i];
}
}
return 0;
} }
void sys_pm_resume_devices(void) void sys_pm_resume_devices(void)