From 20ed64be624175ef8641f80ffae93ec81b96bdc0 Mon Sep 17 00:00:00 2001 From: PawelX Dobrowolski Date: Tue, 6 Dec 2022 12:33:51 +0100 Subject: [PATCH] logging: prevent of NULL pointer comparison Add prevent dereference NULL in strcmp Signed-off-by: PawelX Dobrowolski --- subsys/logging/log_mgmt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/subsys/logging/log_mgmt.c b/subsys/logging/log_mgmt.c index e7609810bff..5d7517b53a8 100644 --- a/subsys/logging/log_mgmt.c +++ b/subsys/logging/log_mgmt.c @@ -359,8 +359,9 @@ void z_log_runtime_filters_init(void) int log_source_id_get(const char *name) { for (int i = 0; i < log_src_cnt_get(Z_LOG_LOCAL_DOMAIN_ID); i++) { - if (strcmp(log_source_name_get(Z_LOG_LOCAL_DOMAIN_ID, i), - name) == 0) { + const char *sname = log_source_name_get(Z_LOG_LOCAL_DOMAIN_ID, i); + + if ((sname != NULL) && (strcmp(sname, name) == 0)) { return i; } }