From 20021abf0a1afc4e81b497531cf194a4b1271a59 Mon Sep 17 00:00:00 2001 From: Daniel Leung Date: Mon, 17 Jul 2023 16:35:07 -0700 Subject: [PATCH] serial: ns16550: check return of clock_control_get_rate() This adds a check of the return of clock_control_get_rate(), and returns error in uart_configure() if unsuccessful in getting clock rate. Fixes #60478 Signed-off-by: Daniel Leung --- drivers/serial/uart_ns16550.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/serial/uart_ns16550.c b/drivers/serial/uart_ns16550.c index 885c3838928..da5bd79fa53 100644 --- a/drivers/serial/uart_ns16550.c +++ b/drivers/serial/uart_ns16550.c @@ -458,8 +458,12 @@ static int uart_ns16550_configure(const struct device *dev, goto out; } - clock_control_get_rate(dev_cfg->clock_dev, dev_cfg->clock_subsys, - &pclk); + if (clock_control_get_rate(dev_cfg->clock_dev, + dev_cfg->clock_subsys, + &pclk) != 0) { + ret = -EINVAL; + goto out; + } } set_baud_rate(dev, cfg->baudrate, pclk);