michaelh/zephyr
1
0
Fork 0
Code Releases Activity

gpio: gpio_cmsdk_ahb: Return error for not supported flag

Browse source 
The code had GPIO_INT_DOUBLE_EDGE siliently ignored, instead lets run
-ENOTSUP so caller knows its not going to work.

Fixes: #12764

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
This commit is contained in:
Kumar Gala 2019-03-07 04:48:48 -06:00 • committed by Kumar Gala
commit 1ec85cf910
1 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
drivers/gpio/gpio_cmsdk_ahb.c
View file

@ -38,7 +38,7 @@ struct gpio_cmsdk_ahb_dev_data {
sys_slist_t gpio_cb;
};
static void cmsdk_ahb_gpio_config(struct device *dev, u32_t mask, int flags)
static int cmsdk_ahb_gpio_config(struct device *dev, u32_t mask, int flags)
{
const struct gpio_cmsdk_ahb_cfg * const cfg = dev->config->config_info;
@ -57,7 +57,7 @@ static void cmsdk_ahb_gpio_config(struct device *dev, u32_t mask, int flags)
/* Setup interrupt config */
if (flags & GPIO_INT) {
if (flags & GPIO_INT_DOUBLE_EDGE) {
/* FIXME: Not supported in this iteration */
return -ENOTSUP;
} else {
/*
* Interrupt type:
@ -83,6 +83,8 @@ static void cmsdk_ahb_gpio_config(struct device *dev, u32_t mask, int flags)
}
cfg->port->altfuncclr = mask;
return 0;
}
/**
@ -98,18 +100,20 @@ static void cmsdk_ahb_gpio_config(struct device *dev, u32_t mask, int flags)
static int gpio_cmsdk_ahb_config(struct device *dev, int access_op,
u32_t pin, int flags)
{
int ret = 0;
switch (access_op) {
case GPIO_ACCESS_BY_PIN:
cmsdk_ahb_gpio_config(dev, BIT(pin), flags);
ret = cmsdk_ahb_gpio_config(dev, BIT(pin), flags);
break;
case GPIO_ACCESS_BY_PORT:
cmsdk_ahb_gpio_config(dev, (0xFFFF), flags);
ret = cmsdk_ahb_gpio_config(dev, (0xFFFF), flags);
break;
default:
return -ENOTSUP;
}
return 0;
return ret;
}
/**