michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: adc: fix overflow and div-by-zero in adc_ad7124_odr_to_fs

Browse source 
Add check for odr <= 0 and cast odr to uint32_t before multiplication
to avoid integer overflow and division by zero.

Fixes: CID 489220

Signed-off-by: sudarsan N <sudarsansamy2002@gmail.com>
This commit is contained in:
sudarsan N 2025-06-06 10:04:01 +05:30 • committed by Benjamin Cabé
commit 1d51942c50
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
drivers/adc/adc_ad7124.c
View file

@ -326,7 +326,12 @@ static uint16_t adc_ad7124_odr_to_fs(const struct device *dev, int16_t odr)
return -EINVAL;
}
odr_sel_bits = DIV_ROUND_CLOSEST(master_clk_freq, odr * 32);
if (odr <= 0) {
LOG_ERR("Invalid ODR value: %d", odr);
return -EINVAL;
}
odr_sel_bits = DIV_ROUND_CLOSEST(master_clk_freq, (uint32_t)odr * 32);
if (odr_sel_bits < ADC_ODR_SEL_BITS_MIN) {
odr_sel_bits = ADC_ODR_SEL_BITS_MIN;