From 1cd5578539dfd220e81f3f183b18b16484c6a68b Mon Sep 17 00:00:00 2001 From: Flavio Ceolin Date: Tue, 16 Jun 2020 14:45:16 -0700 Subject: [PATCH] serial: ns16550: Simplify poll out Simplify poll_out loop. Signed-off-by: Flavio Ceolin --- drivers/serial/uart_ns16550.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/serial/uart_ns16550.c b/drivers/serial/uart_ns16550.c index 95916dcf287..77aabd3d544 100644 --- a/drivers/serial/uart_ns16550.c +++ b/drivers/serial/uart_ns16550.c @@ -539,17 +539,11 @@ static void uart_ns16550_poll_out(struct device *dev, { k_spinlock_key_t key = k_spin_lock(&DEV_DATA(dev)->lock); - while (1) { - /* wait for transmitter to ready to accept a character */ - if ((INBYTE(LSR(dev)) & LSR_THRE) == 0) { - continue; - } - - OUTBYTE(THR(dev), c); - - break; + while ((INBYTE(LSR(dev)) & LSR_THRE) == 0) { } + OUTBYTE(THR(dev), c); + k_spin_unlock(&DEV_DATA(dev)->lock, key); }