michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: thread_metric: Fix cooperative for SMP

Browse source 
The thread metric cooperative benchmark had a subtle flaw on
SMP enabled systems. The reporting/main thread was running at
a higher priority than the "cooperative" threads. When that
reporting thread woke up from its 30 second sleep, there was a
chance that it would change the ordering of the "cooperative"
threads before the test expected it.

This ordering change is not present on UP systems as the current
thread is always in the ready queue. However, on SMP systems the
current thread is not in the ready queue and is re-added to the
end of the list when it is preempted by a higher priority thread.

To work around this, we make the priority of the main/reporting
thread to be the same as the "cooperative" threads. Thus when
the reporting thread wakes, it is added to the end of list and
no longer introduces an unexpected schedule point.

Signed-off-by: Peter Mitsis <peter.mitsis@intel.com>
This commit is contained in:
Peter Mitsis 2025-03-12 18:09:54 -07:00 • committed by Benjamin Cabé
commit 1c5072780f
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/benchmarks/thread_metric/src/tm_cooperative_scheduling_test.c
View file

@ -80,13 +80,14 @@ int main(void)
void tm_cooperative_scheduling_initialize(void) void tm_cooperative_scheduling_initialize(void)
{ {
int prio = CONFIG_MAIN_THREAD_PRIORITY;
/* Create all 5 threads at priority 3. */ /* Create all 5 threads at the same priority as the main thread. */
tm_thread_create(0, 3, tm_cooperative_thread_0_entry); tm_thread_create(0, prio, tm_cooperative_thread_0_entry);
tm_thread_create(1, 3, tm_cooperative_thread_1_entry); tm_thread_create(1, prio, tm_cooperative_thread_1_entry);
tm_thread_create(2, 3, tm_cooperative_thread_2_entry); tm_thread_create(2, prio, tm_cooperative_thread_2_entry);
tm_thread_create(3, 3, tm_cooperative_thread_3_entry); tm_thread_create(3, prio, tm_cooperative_thread_3_entry);
tm_thread_create(4, 3, tm_cooperative_thread_4_entry); tm_thread_create(4, prio, tm_cooperative_thread_4_entry);
/* Resume all 5 threads. */ /* Resume all 5 threads. */
tm_thread_resume(0); tm_thread_resume(0);