michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: display: ssd1673: Fixup dts support

Browse source 
There were several issues in the dts binding for the ssd1673 display:
* binding file mixed description & generation up together
* Use of BASE_LABEL
* orientation-flipped should have been of type boolean

Update the binding file to reflect these changes, and made associated
changes to dts_fixup.h and driver as needed.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
This commit is contained in:
Kumar Gala 2018-10-19 08:12:57 -05:00 • committed by Kumar Gala
commit 1becbfcb8b
3 changed files with 19 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

21
boards/arm/reel_board/dts_fixup.h
View file

@ -16,17 +16,18 @@
#define CONFIG_APDS9960_GPIO_DEV_NAME NORDIC_NRF_I2C_40003000_AVAGO_APDS9960_29_INT_GPIOS_CONTROLLER #define CONFIG_APDS9960_GPIO_DEV_NAME NORDIC_NRF_I2C_40003000_AVAGO_APDS9960_29_INT_GPIOS_CONTROLLER
#define CONFIG_APDS9960_GPIO_PIN_NUM NORDIC_NRF_I2C_40003000_AVAGO_APDS9960_29_INT_GPIOS_PIN #define CONFIG_APDS9960_GPIO_PIN_NUM NORDIC_NRF_I2C_40003000_AVAGO_APDS9960_29_INT_GPIOS_PIN
#define CONFIG_SSD1673_DEV_NAME NORDIC_NRF_SPI_4002B000_SSD1673_LABEL #define CONFIG_SSD1673_DEV_NAME NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_LABEL
#define CONFIG_SSD1673_SPI_FREQ NORDIC_NRF_SPI_4002B000_SSD1673_SPI_MAX_FREQUENCY #define CONFIG_SSD1673_SPI_FREQ NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_SPI_MAX_FREQUENCY
#define CONFIG_SSD1673_SPI_DEV_NAME NORDIC_NRF_SPI_4002B000_SSD1673_BUS_NAME #define CONFIG_SSD1673_SPI_DEV_NAME NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_BUS_NAME
#define CONFIG_SSD1673_SPI_SLAVE_NUMBER NORDIC_NRF_SPI_4002B000_SSD1673_BASE_ADDRESS #define CONFIG_SSD1673_SPI_SLAVE_NUMBER NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_BASE_ADDRESS
#define CONFIG_SSD1673_SPI_GPIO_CS y #define CONFIG_SSD1673_SPI_GPIO_CS y
#define CONFIG_SSD1673_SPI_GPIO_CS_DRV_NAME NORDIC_NRF_SPI_4002B000_CS_GPIOS_CONTROLLER #define CONFIG_SSD1673_SPI_GPIO_CS_DRV_NAME NORDIC_NRF_SPI_4002B000_CS_GPIOS_CONTROLLER
#define CONFIG_SSD1673_SPI_GPIO_CS_PIN NORDIC_NRF_SPI_4002B000_CS_GPIOS_PIN #define CONFIG_SSD1673_SPI_GPIO_CS_PIN NORDIC_NRF_SPI_4002B000_CS_GPIOS_PIN
#define CONFIG_SSD1673_RESET_GPIO_PORT_NAME NORDIC_NRF_SPI_4002B000_SSD1673_RESET_GPIOS_CONTROLLER #define CONFIG_SSD1673_RESET_GPIO_PORT_NAME NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_RESET_GPIOS_CONTROLLER
#define CONFIG_SSD1673_RESET_PIN NORDIC_NRF_SPI_4002B000_SSD1673_RESET_GPIOS_PIN #define CONFIG_SSD1673_RESET_PIN NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_RESET_GPIOS_PIN
#define CONFIG_SSD1673_DC_GPIO_PORT_NAME NORDIC_NRF_SPI_4002B000_SSD1673_DC_GPIOS_CONTROLLER #define CONFIG_SSD1673_DC_GPIO_PORT_NAME NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_DC_GPIOS_CONTROLLER
#define CONFIG_SSD1673_DC_PIN NORDIC_NRF_SPI_4002B000_SSD1673_DC_GPIOS_PIN #define CONFIG_SSD1673_DC_PIN NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_DC_GPIOS_PIN
#define CONFIG_SSD1673_BUSY_GPIO_PORT_NAME NORDIC_NRF_SPI_4002B000_SSD1673_BUSY_GPIOS_CONTROLLER #define CONFIG_SSD1673_BUSY_GPIO_PORT_NAME NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_BUSY_GPIOS_CONTROLLER
#define CONFIG_SSD1673_BUSY_PIN NORDIC_NRF_SPI_4002B000_SSD1673_BUSY_GPIOS_PIN #define CONFIG_SSD1673_BUSY_PIN NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_BUSY_GPIOS_PIN
#define CONFIG_SSD1673_ORIENTATION_FLIPPED NORDIC_NRF_SPI_4002B000_SOLOMON_SSD1673FB_SPI_0_ORIENTATION_FLIPPED

2
drivers/display/ssd1673.c
View file

@ -136,7 +136,7 @@ static inline int ssd1673_set_ram_ptr(struct ssd1673_data *driver,
static inline void ssd1673_set_orientation(struct ssd1673_data *driver) static inline void ssd1673_set_orientation(struct ssd1673_data *driver)
{ {
#if defined(CONFIG_SSD1673_ORIENTATION_FLIPPED) #if CONFIG_SSD1673_ORIENTATION_FLIPPED == 1
driver->scan_mode = SSD1673_DATA_ENTRY_XIYDY; driver->scan_mode = SSD1673_DATA_ENTRY_XIYDY;
#else #else
driver->scan_mode = SSD1673_DATA_ENTRY_XDYIY; driver->scan_mode = SSD1673_DATA_ENTRY_XDYIY;

13
dts/bindings/display/solomon,ssd1673fb.yaml
View file

@ -20,17 +20,20 @@ properties:
height: height:
type: int type: int
category: required category: required
generation: Height in pixel of the panel driven by the controller description: Height in pixel of the panel driven by the controller
generation: define
width: width:
type: int type: int
category: required category: required
generation: Width in pixel of the panel driven by the controller description: Width in pixel of the panel driven by the controller
generation: define
orientation-flipped: orientation-flipped:
type: string type: boolean
category: optional category: optional
generation: Last column address is mapped to first segment description: Last column address is mapped to first segment
generation: define
reset-gpios: reset-gpios:
type: compound type: compound
@ -47,6 +50,4 @@ properties:
category: required category: required
generation: define, use-prop-name generation: define, use-prop-name
base_label: SSD1673
... ...