michaelh/zephyr
1
0
Fork 0
Code Releases Activity

lib: shell: replace strtol with strtoul in cmd_load for address parsing

Browse source 
Addresses in cmd_load() should always be unsigned. Previously, strtol()
was used, which is limited to signed long values, causing issues with
addresses >= 0x80000000. This commit replaces strtol() with strtoul(),
ensuring proper handling of the full 32-bit address space.

Fixes #81343

Signed-off-by: Aaron Fontaine <aaron.fontaine@dojofive.com>
Signed-off-by: Jakub Rzeszutko <jakub.rzeszutko@verkada.com>
This commit is contained in:
Jakub Rzeszutko 2024-11-19 08:54:10 +01:00 • committed by Alberto Escolar
commit 1aaf08f7f1
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
subsys/shell/modules/devmem_service.c
View file

@ -247,8 +247,8 @@ static int cmd_load(const struct shell *sh, size_t argc, char **argv)
argc--;
}
bytes = (unsigned char *)strtol(argv[1], NULL, 0);
data = (uint32_t *)strtol(argv[1], NULL, 0);
bytes = (unsigned char *)strtoul(argv[1], NULL, 0);
data = (uint32_t *)strtoul(argv[1], NULL, 0);
set_bypass(sh, bypass_cb);
return 0;