michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: eth: stm32: Fix invalid assertion comparison

Browse source 
The check for assertion on the "config_func" was added to
validate that the function pointer is valid. However, in
the code we are invoking the "config_func" and comparing
its output with NULL. This causes build failures with
CONFIG_ASSERT=1. Caused by PR-25393.

Tested on Nucleo F767Zi board.

Fixes #25427

Signed-off-by: Bilal Wasim <bilalwasim676@gmail.com>
This commit is contained in:
Bilal Wasim 2020-05-19 03:39:21 +05:00 • committed by Carles Cufí
commit 190ade91b8
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/ethernet/eth_stm32_hal.c
View file

@ -478,7 +478,7 @@ static void eth_iface_init(struct net_if *iface)
dev_data->iface = iface;
/* Now that the iface is setup, we are safe to enable IRQs. */
__ASSERT_NO_MSG(DEV_CFG(dev)->config_func() != NULL);
__ASSERT_NO_MSG(DEV_CFG(dev)->config_func != NULL);
DEV_CFG(dev)->config_func();
}