michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Mesh: Warn log mode incompatibility with friendship

Browse source 
Log modes other than the deferred may cause unintended delays during
processing of log messages. This in turns will affect scheduling of the
receive delay and receive window for both, Friend and LPN.

Adding a compilation warning instead of assert as a user may still want
to compile a code with friendship feature enabled without actually
establishing a friendship.

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
This commit is contained in:
Pavel Vasilyev 2022-12-07 12:27:16 +01:00 • committed by Carles Cufí
commit 163c2bc316
3 changed files with 28 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
subsys/bluetooth/mesh/friend.c
View file

@ -26,6 +26,17 @@
#include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(bt_mesh_friend);
/**
* Log modes other than the deferred may cause unintended delays during processing of log messages.
* This in turns will affect scheduling of the receive delay and receive window.
*/
#if !defined(CONFIG_TEST) && !defined(CONFIG_ARCH_POSIX) && \
defined(CONFIG_LOG) && !defined(CONFIG_LOG_MODE_DEFERRED) && \
(LOG_LEVEL >= LOG_LEVEL_INF)
#warning Frienship feature may work unstable when non-deferred log mode is selected. Use the \
CONFIG_LOG_MODE_DEFERRED Kconfig option when Friend feature is enabled.
#endif
/* We reserve one extra buffer for each friendship, since we need to be able
* to resend the last sent PDU, which sits separately outside of the queue.
*/

11
subsys/bluetooth/mesh/lpn.c
View file

@ -27,6 +27,17 @@
#include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(bt_mesh_lpn);
/**
* Log modes other than the deferred may cause unintended delays during processing of log messages.
* This in turns will affect scheduling of the receive delay and receive window.
*/
#if !defined(CONFIG_TEST) && !defined(CONFIG_ARCH_POSIX) && \
defined(CONFIG_LOG) && !defined(CONFIG_LOG_MODE_DEFERRED) && \
(LOG_LEVEL >= LOG_LEVEL_INF)
#warning Frienship feature may work unstable when non-deferred log mode is selected. Use the \
CONFIG_LOG_MODE_DEFERRED Kconfig option when Low Power node feature is enabled.
#endif
#if defined(CONFIG_BT_MESH_LPN_AUTO)
#define LPN_AUTO_TIMEOUT (CONFIG_BT_MESH_LPN_AUTO_TIMEOUT * MSEC_PER_SEC)
#else